๐ :: (#534) ์ข์์ ํ๋ฉด์ ๋ฆฌ์กํฐํท์ผ๋ก ๋ฆฌํฉํฉ๋๋ค. #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongbeomkwak
requested review from
kimdaehee0824,
KangTaeHoon,
youn9k and
baekteun
as code owners
โ Successful finished SwiftLint |
โ Assign ์๋ ์ง์ ์ ์ฑ๊ณตํ์ด์! |
baekteun
reviewed
May 11, 2024
Comment on lines
24
to
29
| var containSongsFactory: ContainSongsFactory! | ||
| var textPopUpFactory: TextPopUpFactory! | ||
| lazy var input = FavoriteViewModel.Input() | ||
| lazy var output = viewModel.transform(from: input) | ||
| var disposeBag = DisposeBag() | ||
| var signInFactory: SignInFactory! | ||
|
|
||
| public var songCartView: SongCartView! | ||
| public var bottomSheetView: BottomSheetView! | ||
| var songCartView: SongCartView! | ||
| var bottomSheetView: BottomSheetView! |
There was a problem hiding this comment.
private var ๋ถ์ฌ์ฃผ์๋๊ฒ ์ข์๊ฑฐ๊ฐ์์
There was a problem hiding this comment.
๋ถํ์ต๋๋ค ~
songcart์ bottomSheetView๋ ํ๋กํ ์ฝ ์์ฒด๊ฐ public์ด๋ผ ๋ถ๊ฐ๋ฅํ ๋ฏ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐ์
๋ณด๊ดํจ์ ์๋ ๋ง์ง๋ง ํ๋ฉด ์ข์์ ๋ชฉ๋ก์ ๋ฆฌ์กํฐํท์ผ๋ก ๋ฆฌํฉํฉ๋๋ค.
Resolves: #534
๐ ์์ ๋ด์ฉ
๐โโ๏ธ ๋ฆฌ๋ทฐ๋ ธํธ
โ PR ์ฒดํฌ๋ฆฌ์คํธ
XCConfig,๋ ธ์ ,README)"API ๊ฐ๋ฐ ์๋ฃ๋์ด์","XCConfig ๊ฐ ์ถ๊ฐ๋์์ด์")๐ธ ๊ธฐํ