Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#554) pre-push ์‹œ์ ์— SwiftFormat ์ ์šฉ #555

Merged
merged 2 commits into from
May 31, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented May 31, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๊ธฐ์กด์— pre-commit (์ปค๋ฐ‹ ์ „) ์‹œ์ ์— SwiftFormat์„ ๋Œ๋ฆฌ๊ณ  ๊ฐœ๋ฐœ์ž๊ฐ€ ์ง์ ‘ commit์„ ํ•˜๊ฒŒ ํ–ˆ์Šต๋‹ˆ๋‹ค.
๋‹จ, ์ด๋Ÿฌ๋ฉด์„œ ๋Œ€๋‘๋œ ๋ฌธ์ œ์ ์ด ๊ฐœ๋ฐœ์ž๊ฐ€ ๊ฝค๋‚˜ ๋ฒˆ๊ฑฐ๋กœ์›€์„ ๋Š๋ผ๊ฒŒ ๋˜๊ณ  ์ฝ”๋“œ์ƒ์— Format์„ ์ง„ํ–‰ํ•œ ์ปค๋ฐ‹์ด ๊ฑฐ์˜ ์ ˆ๋ฐ˜์„ ๋จน๊ฒŒ ๋  ์ˆ˜๋„ ์žˆ๋‹ค๋Š” ๋“ฑ์˜ ๋ฌธ์ œ์ ์„ ์•ผ๊ธฐํ–ˆ์Šต๋‹ˆ๋‹ค.
๊ฐœ๋ฐœ์ž๊ฐ€ ์ง์ ‘ commit์„ ํ•˜๊ฒŒ ๋œ ์ด์œ ๋Š” ์ˆ˜๋™์œผ๋กœ ์ปค๋ฐ‹ํ•œ๋‹ค๋ฉด ๊ฐœ๋ฐœ์ž์˜ ์˜์ง€๋Œ€๋กœ ์ปค๋ฐ‹์„ ๋ถ„๋ฆฌํ•˜๊ธฐ๊ฐ€ ์–ด๋ ค์›Œ์ง€๊ธฐ ๋•Œ๋ฌธ์ž…๋‹ˆ๋‹ค (pre-commit ์‹œ์ ์— git add . git commit -m "Formatt" ์ด๋Ÿฐ์‹์œผ๋กœ ์ง„ํ–‰ํ–ˆ๋‹ค๋ฉด ๋ฌด์กฐ๊ฑด ๋ชจ๋“  ์ž‘์—…์ด ํ•˜๋‚˜์˜ ์ปค๋ฐ‹์— ์ด๋ฃจ์–ด์ ธ์•ผํ•จ

์ด๋ฅผ ํ•ด๊ฒฐํ•˜๊ธฐ ์œ„ํ•ด SwiftFormat์„ ์ž๋™์œผ๋กœ ๋Œ๋ฆฌ๋Š” ์‹œ์ ์„ pre-commit์—์„œ pre-push๋กœ ์‹œ์  ์ด๋™์„ ์‹œํ‚ต๋‹ˆ๋‹ค

Resolves: #554

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • pre-commit ํŠธ๋ฆฌ๊ฑฐ ์ œ๊ฑฐ
  • pre-push ํŒŒ์ผ ์ถ”๊ฐ€
  • RealmSwift์˜ 10.50.1๋ฒ„์ „์—์„œ Xcode ๋ฒ„์ „๊ณผ์˜ ์˜ค๋ฅ˜๊ฐ€ ๋œจ๊ธฐ์— 10.50.0์œผ๋กœ ์•„์˜ˆ exactํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

  1. ์ง€๊ธˆ pre-push ์ง์ „์— ๋ฌด์กฐ๊ฑด git add . git commit -m "" ๋ฅผ ํ•˜๊ฒŒ ๋˜๋Š”๋ฐ ์œ ์ €์—๊ฒŒ SwiftFormat์„ ๋Œ๋ฆฌ๊ฒ ์Šต๋‹ˆ๊นŒ? ํ˜น์€ Formattingํ•œ ๊ฒฐ๊ณผ๋ฌผ์„ commit๊นŒ์ง€ ํ•˜๊ฒ ์Šต๋‹ˆ๊นŒ?๋ฅผ ๋ฌผ์–ด๋ณผ๊นŒ์š”?

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@baekteun

Copy link

๐Ÿ› ๏ธ ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์Šคํ‚ตํ–ˆ์–ด์š”.

@baekteun baekteun changed the title ๐Ÿ”€ :: [#554] pre-push ์‹œ์ ์— SwiftFormat ์ ์šฉ ๐Ÿ”€ :: (#554) pre-push ์‹œ์ ์— SwiftFormat ์ ์šฉ May 31, 2024
@baekteun baekteun added โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ 2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ ์ค‘ โš™ Setting ๊ฐœ๋ฐœ ํ™˜๊ฒฝ ์„ธํŒ… labels May 31, 2024
@baekteun baekteun merged commit 4048ded into develop May 31, 2024
2 checks passed
@baekteun baekteun deleted the 554-swiftformat-automation-timing-pre-push branch May 31, 2024 14:51
Copy link
Member

@youn9k youn9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ง€๊ธˆ pre-push ์ง์ „์— ๋ฌด์กฐ๊ฑด git add . git commit -m "" ๋ฅผ ํ•˜๊ฒŒ ๋˜๋Š”๋ฐ ์œ ์ €์—๊ฒŒ SwiftFormat์„ ๋Œ๋ฆฌ๊ฒ ์Šต๋‹ˆ๊นŒ? ํ˜น์€ Formattingํ•œ ๊ฒฐ๊ณผ๋ฌผ์„ commit๊นŒ์ง€ ํ•˜๊ฒ ์Šต๋‹ˆ๊นŒ?๋ฅผ ๋ฌผ์–ด๋ณผ๊นŒ์š”?

์žˆ์–ด๋„ ์ข‹๊ณ  ์—†์–ด๋„ ๊ดœ์ฐฎ์•„๋ณด์—ฌ์š”!

@baekteun
Copy link
Member Author

์ง€๊ธˆ pre-push ์ง์ „์— ๋ฌด์กฐ๊ฑด git add . git commit -m "" ๋ฅผ ํ•˜๊ฒŒ ๋˜๋Š”๋ฐ ์œ ์ €์—๊ฒŒ SwiftFormat์„ ๋Œ๋ฆฌ๊ฒ ์Šต๋‹ˆ๊นŒ? ํ˜น์€ Formattingํ•œ ๊ฒฐ๊ณผ๋ฌผ์„ commit๊นŒ์ง€ ํ•˜๊ฒ ์Šต๋‹ˆ๊นŒ?๋ฅผ ๋ฌผ์–ด๋ณผ๊นŒ์š”?

์žˆ์–ด๋„ ์ข‹๊ณ  ์—†์–ด๋„ ๊ดœ์ฐฎ์•„๋ณด์—ฌ์š”!

์—‡ ์ด๋ฏธ ๋จธ์ง€ํ•ด๋ฒ„๋ ธ์œผ๋‹ˆ ์ด์™• ์ด๋ ‡๊ฒŒ ๋œ๊น€์— ์‹ค์ œ ์‚ฌ์šฉํ•ด๋ณด๋ฉด์„œ ๋ฌธ์˜ ๋ฐ›์•„์„œ ๋ณ€๊ฒฝํ• ๊ฒŒ์š”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ ์ค‘ โš™ Setting ๊ฐœ๋ฐœ ํ™˜๊ฒฝ ์„ธํŒ… โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwiftFormat ์ž๋™ํ™” ์‹คํ–‰ ์‹œ์  pre-push๋กœ ๋ณ€๊ฒฝ
4 participants