Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#561) ์™๋ฎค ์ถ”์ฒœ ํ”Œ๋ ˆ์ด๋ฆฌ์ŠคํŠธ ํ™”๋ฉด์„ ๋งŒ๋“ค์–ด์š”. #574

Merged
merged 41 commits into from
Jun 10, 2024

Conversation

yongbeomkwak
Copy link
Member

@yongbeomkwak yongbeomkwak commented Jun 5, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”



  • ๊ฒ€์ƒ‰์ „ ํ™”๋ฉด์—์„œ ์™๋ฎค ์ถ”์ฒœํ”Œ๋ ˆ์ด๋ฆฌ์ŠคํŠธ ์ „์ฒด๋ณด๊ธฐ ํด๋ฆญ ์‹œ ๋ณด์—ฌ์งˆ ํ™”๋ฉด์„ ๊ตฌํ˜‘ํ•ฉ๋‹ˆ๋‹ค.

Resolves: #561

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ์ด์ „ ๊ฐ•์ œ ๋จธ์ง€ ์ดํ›„ ๋‹ฌ๋ฆฐ ์ฝ”๋ฉ˜ํŠธ๋ฅผ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • ๋ฐ๋ชจ ์•ฑ๊ณผ Spy๋ฅผ ํ†ตํ•ด ๋น ๋ฅธ ํ…Œ์ŠคํŠธ๋ฅผ ์ง„ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ปดํฌ์ง€์…”๋„ ๋ ˆ์ด์•„์›ƒ์„ ์ด์šฉํ•˜์—ฌ ํ™”๋ฉด์„ ๊ตฌ์„ฑํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

๊ตฌํ˜„ ์‹œ์— ๊ณ ๋ฏผ์ด์—ˆ๋˜ ์ ๋“ค ํ˜น์€ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์˜๋„๊ฐ€ ์žˆ์—ˆ๋‹ค๋ฉด PR ๋ฆฌ๋ทฐ์˜ ์ดํ•ด๋ฅผ ๋•๊ธฐ ์œ„ํ•ด ์„œ์ˆ ํ•ด์ฃผ์„ธ์š”!

๋˜ํ•œ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์ง‘์ค‘ ํ˜น์€ ์ฝ”๋ฉ˜ํŠธ ํ˜น์€ ์งˆ๋ฌธ์„ ์š”์ฒญํ•˜๋Š” ๊ฒฝ์šฐ์— ์ž‘์„ฑํ•˜๋ฉด ์ข‹์•„์š”!

e.g. ์ž‘์—…์„ ๋๋‚ด์•ผํ•  ์‹œ๊ฐ„์ด ์–ผ๋งˆ ์—†์–ด ํ™•์žฅ์„ฑ๋ณด๋‹ค๋Š” ๋™์ž‘์„ ์œ„์ฃผ๋กœ ๋งŒ๋“ค์—ˆ์–ด์š”! ๊ฐ์•ˆํ•˜๊ณ  ๋ฆฌ๋ทฐํ•ด์ฃผ์„ธ์š”!

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented Jun 5, 2024

โœ… Successful finished SwiftLint

@github-actions github-actions bot added the โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon
Copy link
Contributor

์ด๋ฏธ์ง€๊ฐ€ ์จํด์ด ์•„๋‹ˆ๊ณ  ์ข€ ์ฐŒ๊ทธ๋Ÿฌ์ง„๋“ฏ

@baekteun
Copy link
Member

baekteun commented Jun 5, 2024

์ด๋ฏธ์ง€๊ฐ€ ์จํด์ด ์•„๋‹ˆ๊ณ  ์ข€ ์ฐŒ๊ทธ๋Ÿฌ์ง„๋“ฏ

image ์˜ค์šฐ ๋ญ”๊ฐ€ ๋ฏธ๋ฌ˜ํ•˜๊ฒŒ ๋‘ฅ๊ธ€๊ธฐ๊ฐ€ ์™„์ „ํ•˜์ง€๋Š” ์•Š๋„ค์š”

@yongbeomkwak
Copy link
Member Author

์ด๋ฏธ์ง€๊ฐ€ ์จํด์ด ์•„๋‹ˆ๊ณ  ์ข€ ์ฐŒ๊ทธ๋Ÿฌ์ง„๋“ฏ

์—‡ ์…€์€ ๊ทธ๋Œ€๋กœ ์“ด๊ฑด๋ฐ

@baekteun
Copy link
Member

baekteun commented Jun 5, 2024

์ด๋ฏธ์ง€๊ฐ€ ์จํด์ด ์•„๋‹ˆ๊ณ  ์ข€ ์ฐŒ๊ทธ๋Ÿฌ์ง„๋“ฏ

์—‡ ์…€์€ ๊ทธ๋Œ€๋กœ ์“ด๊ฑด๋ฐ

image

์ˆ˜์‹์œผ๋กœ ํ•ด์„œ ๊นจ์ง„๊ฑฐ๊ฐ™์€๋ฐ layoutSubviews์—์„œ imageView.layer.cornerRadius = frame.height / 2.0 ๋กœ ํ•˜๋Š”๊ฒŒ ์ข‹์„๊ฑฐ๊ฐ™์•„์š”

@KangTaeHoon
Copy link
Contributor

์ด๋ฏธ์ง€๊ฐ€ ์จํด์ด ์•„๋‹ˆ๊ณ  ์ข€ ์ฐŒ๊ทธ๋Ÿฌ์ง„๋“ฏ

์—‡ ์…€์€ ๊ทธ๋Œ€๋กœ ์“ด๊ฑด๋ฐ

image

์ˆ˜์‹์œผ๋กœ ํ•ด์„œ ๊นจ์ง„๊ฑฐ๊ฐ™์€๋ฐ layoutSubviews์—์„œ imageView.layer.cornerRadius = frame.height / 2.0 ๋กœ ํ•˜๋Š”๊ฒŒ ์ข‹์„๊ฑฐ๊ฐ™์•„์š”

์…€ ํฌ๊ธฐ๋ฅผ ์ขŒ์šฐ ์—ฌ๋ฐฑ๋งŒ ๋นผ๊ณ  ์žก์€๊ฑฐ ์•„๋‹Œ๊ฐ€์—ฌ

@yongbeomkwak
Copy link
Member Author

์ด๋ฏธ์ง€๊ฐ€ ์จํด์ด ์•„๋‹ˆ๊ณ  ์ข€ ์ฐŒ๊ทธ๋Ÿฌ์ง„๋“ฏ

์—‡ ์…€์€ ๊ทธ๋Œ€๋กœ ์“ด๊ฑด๋ฐ

image ์ˆ˜์‹์œผ๋กœ ํ•ด์„œ ๊นจ์ง„๊ฑฐ๊ฐ™์€๋ฐ layoutSubviews์—์„œ imageView.layer.cornerRadius = frame.height / 2.0 ๋กœ ํ•˜๋Š”๊ฒŒ ์ข‹์„๊ฑฐ๊ฐ™์•„์š”

์…€ ํฌ๊ธฐ๋ฅผ ์ขŒ์šฐ ์—ฌ๋ฐฑ๋งŒ ๋นผ๊ณ  ์žก์€๊ฑฐ ์•„๋‹Œ๊ฐ€์—ฌ

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-06-05 แ„‹แ…ฉแ„’แ…ฎ 4 56 48

์„น์…˜ ์ธ์…‹์—์„œ ๋นผ๊ฐ€์ง€๊ณ  cell์€ ๊ทธ๋ฃน์—์„œ ๊ทธ๋ƒฅ ์ ˆ๋ฐ˜์œผ๋กœ ํ–ˆ์–ด์š”

@yongbeomkwak yongbeomkwak merged commit fe2272f into develop Jun 10, 2024
3 checks passed
@yongbeomkwak yongbeomkwak deleted the 561-develop-wakmuRecommendList branch June 10, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ
Projects
None yet
4 participants