Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#601) ๋‚ด ์ •๋ณด ํ™”๋ฉด ์ด๋ฏธ์ง€ ๋ฆฌ์†Œ์Šค ๋ณ€๊ฒฝ #616

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jun 17, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์ด๋ฏธ์ง€๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ์–ด์š”.

Resolves: #601

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

์ด๋ฏธ์ง€๋ฅผ ์ถ”๊ฐ€ ๋ฐ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

-์ข‹์•„์š” ๋ฒ„ํŠผ์€ ์—ด๋งคํ•จ ๋ฒ„ํŠผ์œผ๋กœ ๋Œ€์ฒด๋  ์˜ˆ์ •์ž…๋‹ˆ๋‹ค.

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ ๐Ÿฑ Asset ๋ฆฌ์†Œ์Šค ๊ด€๋ จ labels Jun 17, 2024
Copy link

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@youn9k

@KangTaeHoon
Copy link
Contributor

๋ฆฌ์†Œ์Šค๋งŒ ๋ฐ”๊พธ๊ณ  ์ ์šฉ์€ ์•ˆํ•œ๊ฑด๊ฐ€์š”? ์Šค์ƒท์—๋Š” ํŒ€์†Œ๊ฐœ๋ž‘ ๊ณต์ง€์‚ฌํ•ญ์ด๋ž‘ ๋˜‘๊ฐ™์€ ์ด๋ฏธ์ง€๋„ค์š”.

@youn9k
Copy link
Member Author

youn9k commented Jun 17, 2024

๋ฆฌ์†Œ์Šค๋งŒ ๋ฐ”๊พธ๊ณ  ์ ์šฉ์€ ์•ˆํ•œ๊ฑด๊ฐ€์š”? ์Šค์ƒท์—๋Š” ํŒ€์†Œ๊ฐœ๋ž‘ ๊ณต์ง€์‚ฌํ•ญ์ด๋ž‘ ๋˜‘๊ฐ™์€ ์ด๋ฏธ์ง€๋„ค์š”.

์—‡ ๊ทธ๋Ÿฌ๋„ค์š”ใ…‹ใ…‹ใ…‹ใ…‹ ์ ์šฉ์€ ์—ด๋งคํ•จ ๋ฒ„ํŠผ ๋งŒ๋“ค๋•Œ ๊ฐ™์ด ๋“ค์–ด๊ฐˆ๊ฒŒ์š”

@youn9k youn9k merged commit d4b870a into develop Jun 17, 2024
4 checks passed
@youn9k youn9k deleted the 601-replace-icon-myinfo-feature branch June 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ ๐Ÿฑ Asset ๋ฆฌ์†Œ์Šค ๊ด€๋ จ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋‚ด ์ •๋ณด ํ™”๋ฉด ์•„์ด์ฝ˜ ๋ณ€๊ฒฝํ•˜๊ธฐ
3 participants