Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#568) ๋‚ด์ •๋ณด ํ™”๋ฉด์„ DemoApp์œผ๋กœ ๋งŒ๋“ค๊ธฐ ์œ„ํ•œ Factory ์ž‘์—… ๋ฐ ๋‚ด์ •๋ณด ํ™”๋ฉด Demo #620

Merged
merged 17 commits into from
Jun 18, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jun 17, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

#619 PR์— ์ด์–ด ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค.

Resolves: #568

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-17.at.23.19.27.mov
  • ๋‚ด์ •๋ณด ํ™”๋ฉด์—์„œ ์˜์กดํ•˜๋Š” ์ปดํฌ๋„ŒํŠธ๋“ค์„ Stubํ•˜๊ธฐ ์œ„ํ•ด ์ „๋ถ€ Factory Protocol์„ ์ ์šฉํ•˜๊ณ , AppComponent์— ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • ๋‚ด์ •๋ณด ํ™”๋ฉด์—์„œ ์˜์กดํ•˜๋Š” ์ปดํฌ๋„ŒํŠธ๋“ค์„ Stubํ•ฉ๋‹ˆ๋‹ค.
  • ๋‚ด์ •๋ณด ํ™”๋ฉด์„ Stub ํ•ฉ๋‹ˆ๋‹ค.
  • ๋Ž์Šค ์žˆ๋Š” ๋‚ด์ •๋ณด ํ™”๋ฉด์˜ DemoApp ์™„์„ฑ..๐Ÿคฎ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

  • ์ด๋ ‡๊ฒŒ ์—ด์‹ฌํžˆ ํŒฉํ† ๋ฆฌ๋งŒ๋“ค๊ณ  ์˜์กด์„ฑ ์ „๋ถ€ ์—ฐ๊ฒฐํ•˜๊ณ  Stub๋งŒ๋“ค๊ณ ํ•ด๋„ ์Šคํ† ๋ฆฌ๋ณด๋“œ๋กœ ์ž‘์„ฑ๋œ ํ™”๋ฉด์€ ํ„ฐ์ง€๋„ค์š” ใ…‚ใ„ทใ…‚ใ„ท

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง 3๏ธโƒฃ Priority: Low ์šฐ์„ ์ˆœ์œ„ ํ•˜ labels Jun 17, 2024
Copy link

github-actions bot commented Jun 17, 2024

โœ… Successful finished SwiftLint

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@youn9k

@yongbeomkwak
Copy link
Member

์ €๊ฑฐ ์˜คํ”ˆ์†Œ์Šค์— ์ง€๊ธˆ ์•ˆ์“ฐ๋Š”๊ฑฐ ์ œ๊ฑฐ ํ•˜์…”๋„ ๋  ๋“ฏ?

@youn9k
Copy link
Member Author

youn9k commented Jun 18, 2024

์ €๊ฑฐ ์˜คํ”ˆ์†Œ์Šค์— ์ง€๊ธˆ ์•ˆ์“ฐ๋Š”๊ฑฐ ์ œ๊ฑฐ ํ•˜์…”๋„ ๋  ๋“ฏ?

๊ธฐ์žฌ๋œ ๋‚ด์šฉ ๋ง์”€ํ•˜์‹œ๋Š”๊ฑฐ์ฃ ?? ์ด๊ฑด ์ด์Šˆ์— ์ ์–ด๋‘๊ณ  ๋”ฐ๋กœ ์ž‘์—…ํ•˜๋Š”๊ฑธ๋กœํ• ๊ฒŒ์š”

Base automatically changed from 568-stub-outer-myinfo-feature to develop June 18, 2024 06:00
@youn9k youn9k merged commit 0f707ab into develop Jun 18, 2024
3 checks passed
@youn9k youn9k deleted the 568-stub-inner-myinfo-feature branch June 18, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3๏ธโƒฃ Priority: Low ์šฐ์„ ์ˆœ์œ„ ํ•˜ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋‚ด ์ •๋ณด ํ™”๋ฉด Stub
3 participants