-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ :: (#551) PanModal ๋ผ์ด๋ธ๋ฌ๋ฆฌ๋ฅผ FittedSheets๋ก ๋์ฒด #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KangTaeHoon
requested review from
yongbeomkwak,
kimdaehee0824,
youn9k and
baekteun
as code owners
June 17, 2024 16:29
โ Successful finished SwiftLint |
github-actions
bot
added
0๏ธโฃ Priority: Critical
์ฐ์ ์์ ๊ธด๊ธ
๐ Bug
๋ฒ๊ทธ ๊ด๋ จ
labels
Jun 17, 2024
โ ์ด์์ PR์ Labels ๋๊ธฐํ๋ฅผ ์ฑ๊ณตํ์ด์! |
KangTaeHoon
changed the title
๐ :: (#551) PanModal ๋ผ์ด๋ธ๋ฌ๋ฆฌ๋ฅผ FittedSheets๋ก ๋์ฒดํฉ๋๋ค.
๐ :: (#551) PanModal ๋ผ์ด๋ธ๋ฌ๋ฆฌ๋ฅผ FittedSheets๋ก ๋์ฒด
Jun 17, 2024
youn9k
reviewed
Jun 18, 2024
Projects/Modules/Utility/Sources/Extensions/Extension+UIViewController.swift
Show resolved
Hide resolved
youn9k
approved these changes
Jun 18, 2024
yongbeomkwak
approved these changes
Jun 18, 2024
baekteun
approved these changes
Jun 18, 2024
Projects/Modules/Utility/Sources/Extensions/Extension+UIViewController.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐ์
PanModal ๋ผ์ด๋ธ๋ฌ๋ฆฌ์ ์ ์ง๋ณด์ ์ค๋จ์ผ๋ก์ธํด ๋ ์ด์ ์ฌ์ฉํ ์ ์์.
์ด๋ฏธ ํ๋ก์ ํธ์์ ์ฌ์ฉํ๋ SwiftEntryKit์ผ๋ก ๋์ฒดํ๋ ค ํ์ผ๋, ์ด๊ฒ๋ ๋ฌธ์ ๊ฐ ์์์.
๋ค๋ฅธ ๋์ฒด์ ๋ฅผ ์ฐพ๋ค๋ณด๋ FittedSheets ๋ฐ๊ฒฌ.
Resolves: #551
๐ ์์ ๋ด์ฉ
๐โโ๏ธ ๋ฆฌ๋ทฐ๋ ธํธ
https://github.com/gordontucker/FittedSheets
โ PR ์ฒดํฌ๋ฆฌ์คํธ
XCConfig
,๋ ธ์
,README
)"API ๊ฐ๋ฐ ์๋ฃ๋์ด์"
,"XCConfig ๊ฐ ์ถ๊ฐ๋์์ด์"
)๐ธ ๊ธฐํ