Incorrect import when there are two files with the same name but in different directories

[khatchad]

I am seeing an import statement in an initialization file (__init__.py) import the wrong file when there's (at least) two files with the same name but in different directories. For example, consider the following initialization script:

https://github.com/kyzhouhzau/NLPGNN/blob/b9ecec2c6df1b3e40a54511366dcb6085cf90c34/nlpgnn/models/__init__.py#L14-L15

We should import bert.py from the models package. However, in the logs, I am seeing the following:

adding 260 = global:global script nlpgnn/models/albert.py at 122 to PreBB1:0..121
adding 260 = fieldref 260.259 at 123 to PreBB1:0..122
...
adding 262 = global:global script tests/GNN/BERT-TextGCN/bert.py at 125 to PreBB1:0..124
adding 262 = fieldref 262.259 at 126 to PreBB1:0..125
...

Here, albert.py is correct---it comes from models. However, bert.py comes from a test file when it should come from models.

Regression

In this project, there's only one albert.py but two bert.pys. Somehow, we're selecting the wrong one.

Thoughts

We may have missed changes when adding PYTHONPATH when translating from PYTHON to CAst (CAst to IR looks OK).

[khatchad]

While not completely correct for a different reason, I added a small enhancement that seems to be avoiding this issue. I am now seeing in the logs:

adding 260 = global:global script nlpgnn/models/albert.py at 122 to PreBB1:0..121
adding 260 = fieldref 260.259 at 123 to PreBB1:0..122
...
adding 262 = global:global script nlpgnn/models/bert.py at 124 to PreBB1:0..123
adding 262 = fieldref 262.259 at 125 to PreBB1:0..124

It's now picking the correct bert.py by choosing the one in the same (or sub) directory for the script being parsed.