Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollapsedFieldsets.js is missing. #11

Open
aronchi opened this issue Sep 1, 2010 · 7 comments
Open

CollapsedFieldsets.js is missing. #11

aronchi opened this issue Sep 1, 2010 · 7 comments

Comments

@aronchi
Copy link

aronchi commented Sep 1, 2010

Upload form refers to this file, but it's missing:

<script type="text/javascript" src="{% admin_media_prefix %}js/admin/CollapsedFieldsets.js"></script>

I found it in grappelli, I think we should copy it into django-filebrowser-no-grappelli media files.

@wardi
Copy link
Owner

wardi commented Sep 1, 2010

I'm hesitant to add anything from grappelli to -no-grappelli. If it works without the js then we should just remove the link.

@aronchi
Copy link
Author

aronchi commented Sep 1, 2010

It's a useful js, because the popup dimension is fixed and the save button comes easily under the scroll, and it doesn't hurt.

I think you should add it, if you see its code you'll notice it's not a problem...

@wardi
Copy link
Owner

wardi commented Sep 1, 2010

The file is in a grappelli branch but not in trunk, and it looks like code that should be part of the normal django admin, no?

@aronchi
Copy link
Author

aronchi commented Sep 1, 2010

I didn't find that in django admin 1.2.1

@wardi
Copy link
Owner

wardi commented Sep 1, 2010

ok, I'll take a patch that adds that one file

@italomaia
Copy link

collapse.js from django-admin seems to do something similar. Has anyone tried a fix with it?

@wardi
Copy link
Owner

wardi commented Sep 7, 2010

yes, that's what I was looking for. A fix linking to collapse.js would be even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants