Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arweave message #6 #21

Merged
merged 4 commits into from
May 22, 2023
Merged

Arweave message #6 #21

merged 4 commits into from
May 22, 2023

Conversation

szynwelski
Copy link
Contributor

No description provided.

@szynwelski szynwelski force-pushed the szynek/arweave-message#6 branch from bf376d4 to 41ee02e Compare May 19, 2023 12:03
@szynwelski szynwelski requested a review from janekolszak May 19, 2023 12:04
janekolszak
janekolszak approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@janekolszak janekolszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding two issues from the review

x/sequencer/api/arweave.go Show resolved Hide resolved
@szynwelski szynwelski requested a review from ppedziwiatr May 19, 2023 16:38
ppedziwiatr
ppedziwiatr reviewed May 19, 2023
View reviewed changes
x/sequencer/api/arweave.go Show resolved Hide resolved
x/sequencer/api/arweave.go Show resolved Hide resolved
x/sequencer/module_simulation.go Show resolved Hide resolved
x/sequencer/keeper/msg_server_arweave.go Show resolved Hide resolved
x/sequencer/types/message_arweave.go Show resolved Hide resolved
x/sequencer/types/tx.pb.go Show resolved Hide resolved
@ppedziwiatr
Copy link

ppedziwiatr commented May 19, 2023 •
edited
Loading

image

"x/sequencer" - why "x"? is this some Cosmos convention?

@szynwelski
Copy link
Contributor Author

"x/sequencer" - why "x"? is this some Cosmos convention?

Yes, this is the recommended directory structure:
https://docs.cosmos.network/main/building-modules/structure

@janekolszak
Copy link
Contributor

I need this code, so I'm merging

@janekolszak janekolszak merged commit bddbcf9 into main May 22, 2023
@szynwelski szynwelski mentioned this pull request May 22, 2023
Merged
@szynwelski szynwelski mentioned this pull request May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppedziwiatr ppedziwiatr ppedziwiatr left review comments

@janekolszak janekolszak janekolszak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szynwelski @ppedziwiatr @janekolszak