Rate limiter #94
Open
Rate limiter #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
janekolszak
commented
Jan 2, 2024
janekolszak
commented
- Limiter: Generated module implementation
- Limiter: Fix linter errors
- Limiter: Pass limiter's keeper to sequencer's keeper
- Limiter: Simple cache implementation, no synchronization yet
- Limiter: Non-blocking cache implementation
- Limiter: Add controller to LimiterKeeper
- Limiter: Replace map with non-blocking cache
- Limiter: Increment counter when processing L2 interactions
- Limiter: Increment counter when processing L1 interactions
- Limiter: Check limiter's counters before accepting L2 data item
szynwelski
reviewed
Jan 5, 2024
| "github.com/spf13/cobra" | ||
|
|
||
| "github.com/cosmos/cosmos-sdk/client" | ||
| // "github.com/cosmos/cosmos-sdk/client/flags" |
There was a problem hiding this comment.
remove commented imports
| ) | ||
|
|
||
| const ( | ||
| // flagPacketTimeoutTimestamp = "packet-timeout-timestamp" |
|
|
||
| // x/limiter module sentinel errors | ||
| var ( | ||
| // ErrSample = sdkerrors.Register(ModuleName, 1100, "sample error") |
| // Rate limiting | ||
| if !h.ownerWhitelist.Contains(msg.DataItem.Owner.Base64()) && | ||
| h.limiterKeeper.GetCount(sequencer.LIMITER_CONTRACT_ID, []byte(contractId)) > sequencer.LIMITER_CONTRACT_ID_MAX_REQUESTS { | ||
| TooManyRequestsError(w, err, "parse contract id error") |
There was a problem hiding this comment.
change error description
| @@ -22,6 +22,11 @@ func BadRequestError(w http.ResponseWriter, err error, errorType string) { | |||
| ErrorWithStatus(w, err.Error(), errorType, http.StatusBadRequest) | |||
| } | |||
|
|
|||
| // Writes a bad request error in the form of JSON to the HTTP response | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.