feat: Override default build format to Zip when building for Windows

[felipebraga]

Override default build format to Zip when building for Windows

The idea behind it is to enable winget installation due the inability of winget decompress tar files.

[yermulnik]

> git br
* pr/527
  master

> goreleaser check
  • checking                                 path=.goreleaser.yml
  • 1 configuration file(s) validated
  • thanks for using goreleaser!

[yermulnik]

Out of interest: why these two new blank lines?

[yermulnik]

other than that PR looks good to me

[yermulnik]

@felipebraga ?

[yermulnik]

@felipebraga While you're here, could you please trim trailing whitespaces in this file on line 29? Thanks in advance.

[MatthewJohn]

Assuming that windows is in a state that can run shell scripts (I guess cygwin or such), then we need to consider the install script: https://github.com/warrensbox/terraform-switcher/blob/master/install.sh#L345 as it looks for the tar.gz

[yermulnik]

Assuming that windows is in a state that can run shell scripts (I guess cygwin or such), then we need to consider the install script: master/install.sh#L345 as it looks for the tar.gz

Ah, good pointer.
Given the script already supports zip, we should be good to adjust FORMAT conditionally via https://github.com/warrensbox/terraform-switcher/blob/master/install.sh#L89-L92 like it's already done somewhere else, e.g. https://github.com/LilithGames/golangci-lint/blob/master/install.sh#L120-L126

The change looks quite simple, though I don't have Windows laptop to test 🤷🏻

@felipebraga Could you please implement this change and test install.sh script to work as expected on Windows? 🤔

[yermulnik]

Requesting changes as install script needs to be adjusted accordingly.

[MatthewJohn]

Assuming that windows is in a state that can run shell scripts (I guess cygwin or such), then we need to consider the install script: master/install.sh#L345 as it looks for the tar.gz

Ah, good pointer. Given the script already supports zip, we should be good to adjust FORMAT conditionally via https://github.com/warrensbox/terraform-switcher/blob/master/install.sh#L89-L92

I did see that, the comment seems weird though: # change format (tar.gz or zip) based on ARCH

Seems to suggest that format can be changed based on architecture, but archive name can be changed based on OS 🤔

Edit: Ah yeh, that second example implies it should work fine 🥳

[yermulnik]

I did see that, the comment seems weird though: # change format (tar.gz or zip) based on ARCH

Seems to suggest that format can be changed based on architecture, but archive name can be changed based on OS 🤔

Edit: Ah yeh, that second example implies it should work fine 🥳

Yeah, that seems to be a copy-pasta typo that comes from someone else's original script I guess that is used across multiple repos and is based on portable POSIX libs collection at https://github.com/client9/shlib