feat(secrets-vault): Add Secrets Server implementation for Vault #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonas
force-pushed
the
feat/add-secrets-vault
branch
from
6257933
to
ecc3578
Compare
joonas
force-pushed
the
feat/add-secrets-vault
branch
7 times, most recently
from
2bc56e6
to
17a4d31
Compare
joonas
force-pushed
the
feat/add-secrets-vault
branch
2 times, most recently
from
054dd9b
to
cc87c41
Compare
joonas
force-pushed
the
feat/add-secrets-vault
branch
2 times, most recently
from
7ff3687
to
f85d7e3
Compare
joonas
force-pushed
the
feat/add-secrets-vault
branch
3 times, most recently
from
a40bf32
to
32eb611
Compare
brooksmtownsend
requested changes
Jul 25, 2024
joonas
force-pushed
the
feat/add-secrets-vault
branch
4 times, most recently
from
a909a94
to
e8034b3
Compare
joonas
force-pushed
the
feat/add-secrets-vault
branch
2 times, most recently
from
026651e
to
5fd018b
Compare
brooksmtownsend
approved these changes
Jul 29, 2024
secrets/secrets-vault/Cargo.toml
Outdated
Comment on lines
26
to
27
| # TODO: update this to use the published crate once it exists. | ||
| wasmcloud-secrets-types = { version = "0.1.0", git = "https://github.com/wasmcloud/wasmCloud.git", branch = "main" } |
There was a problem hiding this comment.
I will also need secrets-client published so that there isn't a conflict between the types used by the git-based secrets-client and the published secrets-type crate.
There was a problem hiding this comment.
Tag pushed 😉 Should be ready here in just a bit
Co-authored-by: Brooks Townsend <brooksmtownsend@gmail.com> Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
joonas
force-pushed
the
feat/add-secrets-vault
branch
from
5fd018b
to
29e9c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This adds a Secrets RFC Secrets Server implementation for HashiCorp Vault
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification