feat: Add support for configuring observability via WasmCloudHostConfig #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
joonas
force-pushed
the
feat/enable-observability
branch
from
8110957
to
f83dbf9
Compare
thomastaylor312
approved these changes
Jul 1, 2024
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "wasmcloud-operator-types" | |||
| version = "0.1.5" | |||
| version = "0.1.6" | |||
There was a problem hiding this comment.
Super Nit: Technically this should be 0.2.0 since you're adding new features
There was a problem hiding this comment.
you're absolutely right, this should probably be a 0.2.0, I think we've broken the rule about patch versions a number of times already, so I think we'll probably want to have that conversation when we do the work to move to v1alpha2.
| #[serde(rename_all = "camelCase")] | ||
| pub struct ObservabilityConfiguration { | ||
| #[serde(default)] | ||
| pub enable: bool, |
There was a problem hiding this comment.
Should we be adding the documentation to each of these options so people know what they do? I know we have the command line flags, but wasn't sure if we were documenting these or not
There was a problem hiding this comment.
We should, I'll follow-up with a PR that does the documenting part, including the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This adds the ability to configure the various observability options via
WasmCloudHostConfigby adding:It also has the ability to optionally override the endpoint for any of the signals, and the protocol (default is
http)Related Issues
Fixes #49
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification