chore: Add dependency-review workflow for pull requests #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
joonas
commented
Mar 29, 2024
| # https://github.com/actions/dependency-review-action?tab=readme-ov-file#configuration-options | ||
| fail-on-severity: critical | ||
|
|
||
| comment-summary-in-pr: always |
There was a problem hiding this comment.
We could switch this to on-failure, but I figured always would be nice to start with to see what this looks like in practice.
There was a problem hiding this comment.
Yeah, let's see what it looks like for now.
joonas
commented
Mar 29, 2024
| - name: Dependency Review | ||
| uses: actions/dependency-review-action@v4 | ||
| with: | ||
| config-file: './.github/dependency-review-config.yml' |
There was a problem hiding this comment.
We might want to consider pointing this to an external reference at some point via something like this:
# Syntax for an external file: OWNER/REPOSITORY/FILENAME@BRANCH
config-file: 'wasmcloud/wasmcloud-operator/.github/dependency-review-config.yml@main'
But for now I think it should be fine as it is.
protochron
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
GitHub recently announced the addition of OpenSSF Scorecard support in the
dependency-reviewGitHub Action, which brought this action to my attention.Having looked at it, this looks like it could be a useful addition for the PR pipeline in order to help maintain awareness of the state of dependencies that are being introduced/changed.
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification