Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or silence wasmi_wast warnings #1288

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Nov 4, 2024

These warning fixes can be removed once wasmi_wast uses the next version of the wast crate (v220) which includes fixes for these issues: bytecodealliance/wasm-tools#1891

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.53%. Comparing base (5b344ca) to head (9059145).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wast/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1288   +/-   ##
=======================================
  Coverage   81.52%   81.53%           
=======================================
  Files         306      306           
  Lines       25277    25275    -2     
=======================================
  Hits        20607    20607           
+ Misses       4670     4668    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit b604811 into main Nov 4, 2024
18 of 19 checks passed
@Robbepop Robbepop deleted the rf-fix-warnings-in-wasmi-wast branch November 4, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant