Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C API: Fix function name of compilation mode setter #1298

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

turbolent
Copy link
Contributor

config.h defines WASMI_CONFIG_PROP to define setters for configuration options as wasmi_config_##name##_set. Just like for all other configuration options, this macro is used for compilation_mode. However, the function is exported from the c_api crate with a different name.

Fix the exported name and make it consistent with the other configuration options.

@turbolent
Copy link
Contributor Author

It might make sense to add some tests for the C API to ensure the headers and the library can be used successfully.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (68205d4) to head (01da862).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1298   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files         306      306           
  Lines       25308    25308           
=======================================
+ Hits        20649    20650    +1     
+ Misses       4659     4658    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop
Copy link
Member

Robbepop commented Nov 7, 2024

It might make sense to add some tests for the C API to ensure the headers and the library can be used successfully.

Yes, totally! I wanted to do this a long time ago but there are so many things with a higher priority right now. Missing automated tests is why I flagged the C-API as experimental so far. Though, I am very happy about help and PRs. :)

@Robbepop
Copy link
Member

Robbepop commented Nov 7, 2024

@turbolent Thanks a lot for the fix!

@Robbepop Robbepop merged commit b78079c into wasmi-labs:main Nov 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants