HTTP/2 support #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I needed HTTP/2 support for my project. I also implemented missing text status message according to specs:
whatwg/fetch#599
I emulated curl response in terms of HTTP/2.
curl/curl#1081
I've made sure tests pass through.
One breaking change is that I got rid of major/minor protocol version integers, which I consider to be a bit of over-engineered feature - now the protocol version is just '2' or '1.0' or '1.1' string. This can be easily removed from the PR though, I understand this might be a bad idea to mix such features in one patch.