-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamped alert browser list page changes #1038
Conversation
…vi-revamped-alert-browser
…vi-revamped-alert-browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Shavi,
Approving but could you please have a look at my comments?
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the callouts shouldn't be punctuated because they are not complete sentences but object names.
Only "Click to see the menu." is a complete sentence but, for consistency, we can change it to something like "Alert menu".
Not sure that "Number of alerts that fired" is correct because it's one alert here. I think it should be something like "Number of alert firings.
Not sure what the brackets mean in the last callout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the alert_firing_severe.png image, too?
For each alert, the Alerts Browser includes detailed information. For example, an alert that is firing looks like this:
-->
You can expand each alert to view detailed information. For example, when you expand an alert that is firing, the detailed information looks like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, we can add a green box around Delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, we can add a green box around Edit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, we can add a green box around Show firings?
Thank you! Great feedback. I will address these in a separate PR. |
Includes update to show the revamped alert browser list changes.