Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop manually adding brackets when metric has no label #20

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

wazazaby
Copy link
Owner

@wazazaby wazazaby commented Nov 6, 2023

Self explanatory.

VM doesn't require brackets, and it actually creates a "bug" where a histogram with no label will get a prefixing comma on the vmrange label like so :

metric_name_bucket{,vmrange="2.154e+01...2.448e+01"}

Which causes querying problems on Grafana somehow 🤔

@wazazaby wazazaby added the bug Something isn't working label Nov 6, 2023
@wazazaby wazazaby self-assigned this Nov 6, 2023
@wazazaby wazazaby merged commit 860f91e into master Nov 6, 2023
1 check passed
@wazazaby wazazaby deleted the hotfix/v1.0.3 branch November 6, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant