Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more logs when the input data is wrong somehow #28

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

vrischmann
Copy link
Contributor

This PR improves the logs to help track down where a label might be wrong.

Before:

2024-01-29T16:14:59.659+0100	INFO	vimebu@v1.1.0/vimebu.go:171	label value must not be empty, skipping
2024-01-29T16:14:59.659+0100	INFO	vimebu@v1.1.0/vimebu.go:171	label value must not be empty, skipping
2024-01-29T16:14:59.660+0100	INFO	vimebu@v1.1.0/vimebu.go:171	label value must not be empty, skipping
2024-01-29T16:14:59.660+0100	INFO	vimebu@v1.1.0/vimebu.go:171	label value must not be empty, skipping
2024-01-29T16:14:59.660+0100	INFO	vimebu@v1.1.0/vimebu.go:171	label value must not be empty, skipping
2024-01-29T16:14:59.660+0100	INFO	vimebu@v1.1.0/vimebu.go:171	label value must not be empty, skipping

After:

2024-01-29T16:13:10.496+0100	INFO	vimebu/vimebu.go:171	metric: "kafka_broker_connect", label name: "host", label value must not be empty, skipping
2024-01-29T16:13:10.497+0100	INFO	vimebu/vimebu.go:171	metric: "kafka_broker_write_wait", label name: "host", label value must not be empty, skipping
2024-01-29T16:13:10.497+0100	INFO	vimebu/vimebu.go:171	metric: "kafka_broker_bytes_written", label name: "host", label value must not be empty, skipping
2024-01-29T16:13:10.497+0100	INFO	vimebu/vimebu.go:171	metric: "kafka_broker_write_latencies", label name: "host", label value must not be empty, skipping

@wazazaby wazazaby self-requested a review January 29, 2024 16:08
Copy link
Owner

@wazazaby wazazaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :)

@wazazaby wazazaby merged commit 722e5a0 into wazazaby:master Jan 29, 2024
1 check passed
@vrischmann vrischmann deleted the improve-logs branch January 29, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants