-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement execution ID to workflow engine #5115
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wazuh-qa into enhancement/4665-dtt1-poc
…ugin Enhancement/4736 dtt1 influxdb plugin
…-workflow Merge workflow engine into main DTT1 branch
…sion-module-improvements-and-fixes
…odule-improvements-and-fixes Merge provision module into main DTT1
…-fixes' into enhancement/4940-dtt1-provision-multiple-dependencies-inventories
…ultiple-dependencies-inventories Enhancement/4940 dtt1 provision multiple dependencies inventories
…-allocation-module-change-the-location-of-the-inventory-and-track-files Moved the inventory file and track file to instance dir
…ion-module-fix-box_version-param-casting-to-str Cast box and box_version to str
…l variables into the workflow
8 tasks
4 tasks
8 tasks
pro-akim
previously approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Notes
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the possibility to have and use internal/magic variables in the workflow execution, it is something similar to what Ansible have (link). For now only one variable is configured, the
execution_id
this var will be used to easily identify each execution and its reports on the observability module.The magic variables are also configured in each execution as
environment
vars, so any tool, module, script executed in a task can access these variables through the ENV vars.The InfluxDB pytest plugin was also updated to take adventage of this new variable.
Usage + Test proof
Basically there are two ways to take adventage of this magic variables:
workflow.yaml
test.py
workflow.yaml
test.py
Extra
A new
env
tag was implemented in the Task block to let the user define environment variables that can be used in the task execution.workflow.yaml
test.py