Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Abstractions #28

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Random Abstractions #28

merged 2 commits into from
Oct 27, 2023

Conversation

wbaldoumas
Copy link
Owner

Description

Abstractions for randomness:

  • A thread-local random implementation
  • A IRandomTrueIndexSelector and segmented implementation, which will be used to randomly select valid chord choices

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6b95f80) 100.00% compared to head (ba8cd31) 99.48%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #28      +/-   ##
===========================================
- Coverage   100.00%   99.48%   -0.52%     
===========================================
  Files           19       21       +2     
  Lines          350      389      +39     
  Branches        20       27       +7     
===========================================
+ Hits           350      387      +37     
- Misses           0        1       +1     
- Partials         0        1       +1     
Files Coverage Δ
...ibrary/Collections/CompressedBitArrayDictionary.cs 100.00% <ø> (ø)
...BaroquenMelody.Library/Random/ThreadLocalRandom.cs 100.00% <100.00%> (ø)
...Library/Random/SegmentedRandomTrueIndexSelector.cs 93.93% <93.93%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wbaldoumas wbaldoumas marked this pull request as ready for review October 27, 2023 23:18
@wbaldoumas wbaldoumas merged commit 436c52a into main Oct 27, 2023
7 of 9 checks passed
@wbaldoumas wbaldoumas deleted the random-abstractions branch October 27, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant