Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OscryptoDownloader on python 3.8 #1677

Merged
merged 1 commit into from
May 18, 2024
Merged

Conversation

deathaxe
Copy link
Collaborator

caused by #1676

This PR ...

  1. starts fading out OscryptoDownloader by disabling it on python 3.8 (aka ST4) platforms.
  2. fixes original logic to disable OscryptoDownloader for ST3 on linux.

Reasons:

  1. OscryptoDownloader relies on oscrypto which hasn't seen any viable updates for about 2 years at the time of writing this.
  2. MacOS related CI tests for python 3.8 start failing as Github Actions moved to ARM platform. The downloader just gets stuck without any error messages.

@deathaxe deathaxe merged commit 386b1f5 into master May 18, 2024
8 checks passed
@deathaxe deathaxe deleted the fix/fadeout-oscrypto branch May 18, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant