Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jalali calendar and font support #619

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Jalali calendar and font support #619

wants to merge 24 commits into from

Conversation

SaeedZhiany
Copy link
Contributor

@SaeedZhiany SaeedZhiany commented Oct 7, 2019 •
edited
Loading

This PR

adds

  1. Jalali calendar support
  2. Custom font support
  3. function call for setting a locale for calendars

fixes

  1. test failures in sample app

break changes

  1. DatePickerDialog.newInstance and TimePickerDialog.newInstance should passed a calendar type
  2. DatePickerDialog.initialize and TimePickerDialog.initialize should passed a calendarType

TODOs

  • should update README.md file base on new changes

ScreenShots

time date
Screenshot_1570464316 Screenshot_1570464338
Screenshot_1570464472 Screenshot_1570464514
Screenshot_1570464488 Screenshot_1570464532
Screenshot_1570464572 Screenshot_1570464627
Screenshot_1570464600 Screenshot_1570464644
Screenshot_1570464685
Screenshot_1570464715

@SaeedZhiany
Added Jalali Calendar implementation
6b5c939
@SaeedZhiany
Added a default font to using for Persian text and numbers in Jalali …
d33cf60 
…calendar
@SaeedZhiany
Used 'AccessibleTextView' instead of 'TextView'
779d84f
@SaeedZhiany
Used 'start' gravity instead of 'left' according to google suggestion…
c641592 
… to support RTL
@SaeedZhiany
Added focusable property as it's needed when the 'clickable' property…
b89ff37 
… is defined
@SaeedZhiany
extracted commonly used enums and removed similar and duplicated enums.
2b6b7ce
@SaeedZhiany
added new enum for Calendar type supported by library
0563bdd
@SaeedZhiany
used 'VersionCodes' instead of hardcoded version number
e3925c2
@SaeedZhiany
added Jalali calendar support to library and adapted sample project w…
fa1fcf0 
…ith new changes
@SaeedZhiany
added custom font support to library
297fa46
@SaeedZhiany
fixed deprecated usage of AndroidJUnit4 by using 'androidx.test.ext:j…
fdb4ed2 
…unit' package
@SaeedZhiany
Upgraded junit-quickcheck dependencies to the latest.
d9d1e68
@SaeedZhiany
fixed sample project test failure.
54952df
@SaeedZhiany
replaced single case switch with if statement according to android st…
8dd537e 
…udio suggestion.
@SaeedZhiany
used 'VersionCodes' instead of hardcoded version number
130233f
@SaeedZhiany
removed redundant array item initialization
a5b909d
@SaeedZhiany
changed week start day on locale changes
a2ae81e
@SaeedZhiany
Changed sample persian font
fb926ed
@SaeedZhiany
Added an option to change locale from UI in Date Tab
4097bb9
@SaeedZhiany
added locale support to JalaliCalendar class
863e3d2
@SaeedZhiany
Upgrade library's version
e819151
@SaeedZhiany
Applied Android Studio automatic code refactor and optimize import pr…
f0987bb 
…ocedure
@SaeedZhiany
Copy link
Contributor Author

@wdullaer
please review this PR and test it yourself too on a real device or an emulator and let me know what you're thinking about.

This was referenced Oct 7, 2019
Closed
Open
@SaeedZhiany
Copy link
Contributor Author

@wdullaer please review this.

@poyanayeri
Copy link

poyanayeri commented Nov 14, 2019 •
edited
Loading

سلام ,
میشه لطفا راهنمایی کنید چطوری میشه این تقویم جلالی رو به پروژه اضاف کرد ؟
ممنون میشم.

@habibi-dev
Copy link

We are still waiting :|

@SaeedZhiany
Copy link
Contributor Author

@poyanayeri and @habibi-dev

There's no more work I can do, I'm also waiting for @wdullaer to reviewing this.
meanwhile, you can download the project (including this branch) from my forked repository and add it as a module in your android studio and use it. Or you can use this library

@SaeedZhiany SaeedZhiany requested a review from wdullaer February 5, 2020 14:02
@AzadMohammadi-z
Copy link

Does it work for react native ?

@SaeedZhiany
Copy link
Contributor Author

@AzadMohammadi-z

It's a native android library. you should write an RN wrapper for it if you want to use it in RN projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdullaer wdullaer Awaiting requested review from wdullaer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SaeedZhiany @poyanayeri @habibi-dev @AzadMohammadi-z