Error shown for wrong user input in filter #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this issue also cleaned up some code
…e-drawer component as it was not used anywhere
changed test accordingly
Matthbo
reviewed
May 21, 2024
Matthbo
previously approved these changes
May 21, 2024
philipsens
requested changes
May 22, 2024
src/app/debug/filter-side-drawer/filter-side-drawer.component.ts
Outdated
Show resolved
Hide resolved
… the validator if-statements in filter service
… filter-side-drawer.component.ts
MatthijsSmets
previously approved these changes
May 24, 2024
src/app/debug/filter-side-drawer/filter-side-drawer.component.ts
Outdated
Show resolved
Hide resolved
philipsens
previously approved these changes
May 28, 2024
philipsens
reviewed
May 28, 2024
Matthbo
approved these changes
May 28, 2024
MatthijsSmets
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not be merged without merge of PR #239 of the ladybug project.
In the backend the types for each metadata is given through the API to the frontend. User input for the filter is now being validated. If it's the wrong type, it will display an error and will not submit the input given by the user to filter.