Skip to content

Commit

Permalink
Upgrade from javax to jakarta
Browse files Browse the repository at this point in the history
  • Loading branch information
jacodg committed May 24, 2024
1 parent 03691aa commit 80b216a
Show file tree
Hide file tree
Showing 25 changed files with 37 additions and 143 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ Clone the following projects to your Git folder or any other folder of your choi
- https://github.com/wearefrank/frank-runner (building and running the test webapp with Ladybug)
- https://github.com/frankframework/frankframework (in case you want to test your Ladybug changes with the Frank!Framework)

Create skip-replace-inject.txt in checkout directory of the ladybug project. You do not have to give it any contents. If you want to understand the purpose of this file, then see `pom.xml`.

Backend development
-------------------

Expand Down
44 changes: 2 additions & 42 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
<cxf.version>4.0.4</cxf.version>
<jackson.version>2.17.1</jackson.version>
<logback.version>1.5.6</logback.version>
<!-- Create skip-replace-inject.txt (replacement is only needed in the published jar by CI/CD) (more info in nl/nn/testtool/Inject.java -->
<inject.replace.include>**/*.java</inject.replace.include>
<inject.replace.from>javax.inject</inject.replace.from>
<inject.replace.to>nl.nn.testtool</inject.replace.to>
</properties>

<organization>
Expand Down Expand Up @@ -221,7 +217,7 @@
<dependency>
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-api</artifactId>
<version>2.0.2</version>
<version>4.0.1</version>
<scope>provided</scope>
</dependency>
<!-- Resolve @JsonbTransient -->
Expand All @@ -245,31 +241,6 @@
<build>
<defaultGoal>install</defaultGoal>
<plugins>
<plugin>
<groupId>com.google.code.maven-replacer-plugin</groupId>
<artifactId>replacer</artifactId>
<version>1.5.3</version>
<executions>
<execution>
<phase>generate-resources</phase><!-- generate-resources instead of generate-sources to run after copyright check with <phase>process-sources</phase> -->
<goals>
<goal>replace</goal>
</goals>
</execution>
</executions>
<configuration>
<basedir>${basedir}</basedir>
<includes>
<include>${inject.replace.include}</include>
</includes>
<replacements>
<replacement>
<token>import ${inject.replace.from}.Inject;</token>
<value>import ${inject.replace.to}.Inject;</value>
</replacement>
</replacements>
</configuration>
</plugin>
<!--
Add META-INF/jandex.idx, see also:
https://quarkus.io/guides/cdi-reference#how-to-generate-a-jandex-index
Expand Down Expand Up @@ -403,7 +374,7 @@
<artifactId>maven-site-plugin</artifactId>
<version>3.12.1</version>
<configuration>
<skip>true</skip><!-- Prevent copyright check running a second time and failing because of replacements by replacer-plugin. And speed up the build in Jenkins (generated site isn't used) -->
<skip>true</skip><!-- Speed up the build in Jenkins (generated site isn't used) -->
</configuration>
</plugin>
</plugins>
Expand Down Expand Up @@ -489,17 +460,6 @@
</scm>

<profiles>
<profile>
<id>skip-replace-inject</id>
<activation>
<file>
<exists>skip-replace-inject.txt</exists>
</file>
</activation>
<properties>
<inject.replace.include>DISABLE</inject.replace.include>
</properties>
</profile>
<profile>
<id>skip-copyright</id>
<activation>
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/nl/nn/testtool/Config.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
import java.util.ArrayList;
import java.util.List;

import javax.enterprise.inject.Produces;
import javax.inject.Singleton;
import javax.sql.DataSource;

import org.springframework.beans.factory.annotation.Qualifier;
Expand All @@ -32,6 +30,8 @@
import org.springframework.transaction.TransactionManager;

import io.quarkus.arc.DefaultBean;
import jakarta.enterprise.inject.Produces;
import jakarta.inject.Singleton;
import nl.nn.testtool.echo2.ComparePane;
import nl.nn.testtool.echo2.DebugPane;
import nl.nn.testtool.echo2.Echo2Application;
Expand Down
46 changes: 0 additions & 46 deletions src/main/java/nl/nn/testtool/Inject.java

This file was deleted.

5 changes: 2 additions & 3 deletions src/main/java/nl/nn/testtool/TestTool.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,14 @@
import java.util.Set;
import java.util.concurrent.ThreadLocalRandom;

import javax.enterprise.context.ApplicationScoped;
import javax.inject.Inject;

import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;

import jakarta.annotation.PostConstruct;
import jakarta.enterprise.context.ApplicationScoped;
import jakarta.inject.Inject;
import lombok.Getter;
import lombok.Setter;
import lombok.SneakyThrows;
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/nl/nn/testtool/echo2/ComparePane.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@
import java.util.ArrayList;
import java.util.List;

import javax.enterprise.context.Dependent;
import javax.inject.Inject;

import org.springframework.beans.factory.annotation.Autowired;

import jakarta.annotation.PostConstruct;
import jakarta.annotation.Resource;
import jakarta.enterprise.context.Dependent;
import jakarta.inject.Inject;
import nextapp.echo2.app.Extent;
import nextapp.echo2.app.SplitPane;
import nextapp.echo2.extras.app.layout.TabPaneLayoutData;
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/nl/nn/testtool/echo2/ContentPane.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2022 WeAreFrank!
Copyright 2022, 2024 WeAreFrank!
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand All @@ -15,7 +15,7 @@
*/
package nl.nn.testtool.echo2;

import javax.enterprise.context.Dependent;
import jakarta.enterprise.context.Dependent;

@Dependent
public class ContentPane extends nextapp.echo2.app.ContentPane {
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/nl/nn/testtool/echo2/DebugPane.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,12 @@

import java.util.List;

import javax.enterprise.context.Dependent;
import javax.inject.Inject;

import org.springframework.beans.factory.annotation.Autowired;

import jakarta.annotation.PostConstruct;
import jakarta.annotation.Resource;
import jakarta.enterprise.context.Dependent;
import jakarta.inject.Inject;
import nextapp.echo2.app.Extent;
import nextapp.echo2.app.SplitPane;
import nextapp.echo2.extras.app.layout.TabPaneLayoutData;
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/nl/nn/testtool/echo2/Echo2Application.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
import java.util.ArrayList;
import java.util.List;

import javax.enterprise.context.Dependent;
import javax.inject.Inject;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.BeansException;
Expand All @@ -32,6 +29,8 @@

import echopointng.tree.DefaultMutableTreeNode;
import jakarta.annotation.PostConstruct;
import jakarta.enterprise.context.Dependent;
import jakarta.inject.Inject;
import nextapp.echo2.app.ApplicationInstance;
import nextapp.echo2.app.Border;
import nextapp.echo2.app.Button;
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/nl/nn/testtool/echo2/TestPane.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,11 @@
*/
package nl.nn.testtool.echo2;

import javax.enterprise.context.Dependent;
import javax.inject.Inject;

import org.springframework.beans.factory.annotation.Autowired;

import jakarta.annotation.PostConstruct;
import jakarta.enterprise.context.Dependent;
import jakarta.inject.Inject;
import nextapp.echo2.app.Extent;
import nextapp.echo2.app.SplitPane;
import nextapp.echo2.extras.app.layout.TabPaneLayoutData;
Expand Down
7 changes: 3 additions & 4 deletions src/main/java/nl/nn/testtool/filter/View.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2020, 2022-2023 WeAreFrank!, 2018, 2019 Nationale-Nederlanden
Copyright 2020, 2022-2024 WeAreFrank!, 2018, 2019 Nationale-Nederlanden
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand All @@ -18,11 +18,10 @@
import java.util.List;
import java.util.Map;

import javax.enterprise.context.Dependent;
import javax.inject.Inject;

import org.springframework.beans.factory.annotation.Autowired;

import jakarta.enterprise.context.Dependent;
import jakarta.inject.Inject;
import lombok.Getter;
import lombok.Setter;
import nl.nn.testtool.Checkpoint;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import java.util.GregorianCalendar;
import java.util.List;

import javax.inject.Inject;
import javax.sql.DataSource;

import org.apache.commons.lang3.StringUtils;
Expand All @@ -45,6 +44,7 @@
import org.springframework.transaction.annotation.Transactional;

import jakarta.annotation.PostConstruct;
import jakarta.inject.Inject;
import lombok.Getter;
import lombok.Setter;
import lombok.SneakyThrows;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,13 @@

import java.sql.SQLException;

import javax.inject.Inject;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.jdbc.support.JdbcUtils;
import org.springframework.jdbc.support.MetaDataAccessException;

import jakarta.annotation.PostConstruct;
import jakarta.inject.Inject;
import lombok.Setter;

/*
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/nl/nn/testtool/storage/file/Storage.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@

import java.util.List;

import javax.inject.Inject;

import org.springframework.beans.factory.annotation.Autowired;

import jakarta.annotation.PostConstruct;
import jakarta.inject.Inject;
import nl.nn.testtool.MetadataExtractor;
import nl.nn.testtool.Report;
import nl.nn.testtool.storage.StorageException;
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/nl/nn/testtool/storage/file/TestStorage.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,10 @@
import java.util.Iterator;
import java.util.List;

import javax.inject.Inject;

import org.springframework.beans.factory.annotation.Autowired;

import jakarta.annotation.PostConstruct;
import jakarta.inject.Inject;
import nl.nn.testtool.MetadataExtractor;
import nl.nn.testtool.Report;
import nl.nn.testtool.storage.StorageException;
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/nl/nn/testtool/storage/memory/Storage.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,10 @@
import java.util.List;
import java.util.Map;

import javax.inject.Inject;

import org.springframework.beans.factory.annotation.Autowired;

import jakarta.annotation.PostConstruct;
import jakarta.inject.Inject;
import nl.nn.testtool.MetadataExtractor;
import nl.nn.testtool.Report;
import nl.nn.testtool.storage.CrudStorage;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2022 WeAreFrank!
Copyright 2022, 2024 WeAreFrank!
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand All @@ -17,10 +17,9 @@

import java.util.List;

import javax.inject.Inject;

import org.springframework.beans.factory.annotation.Autowired;

import jakarta.inject.Inject;
import lombok.Setter;
import nl.nn.testtool.filter.View;
import nl.nn.testtool.storage.LogStorage;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,11 @@
import java.util.Arrays;
import java.util.List;

import javax.inject.Inject;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;

import jakarta.inject.Inject;
import lombok.Setter;
import nl.nn.testtool.Checkpoint;
import nl.nn.testtool.Report;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2022-2023 WeAreFrank!
Copyright 2022-2024 WeAreFrank!
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand All @@ -17,10 +17,9 @@

import java.util.List;

import javax.inject.Inject;

import org.springframework.beans.factory.annotation.Autowired;

import jakarta.inject.Inject;
import lombok.Setter;
import nl.nn.testtool.filter.View;
import nl.nn.testtool.storage.LogStorage;
Expand Down
Loading

0 comments on commit 80b216a

Please sign in to comment.