Changed metadataApi class so it accepts multiple filters now #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of only one. this is necessary for issue 290 of the ladybug-frontend project
…h null if it wasn't the last in the queue and would duplicate searchvalues
philipsens
reviewed
Apr 23, 2024
philipsens
reviewed
Apr 23, 2024
…no longer necessary
philipsens
reviewed
Apr 29, 2024
philipsens
approved these changes
Apr 29, 2024
jacodg
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for issue 290 of the ladybug frontend project.
Functionality for multiple filters was already present, but not correctly implemented as it would only accept one filter parameter from the getMetadataList GET request. Resulting in only the first filter to be sent to the api to work and all others would be ignored.