Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getWarningsAndErrors() to API #234

Merged
merged 1 commit into from
May 3, 2024
Merged

Add getWarningsAndErrors() to API #234

merged 1 commit into from
May 3, 2024

Conversation

mhdirkse
Copy link
Member

@mhdirkse mhdirkse commented May 3, 2024

No description provided.

@mhdirkse
Copy link
Member Author

mhdirkse commented May 3, 2024

Combined with ladybug-test-webapp PR wearefrank/ladybug-test-webapp#16, the code of this PR was tested as follows:

$ curl -i http://localhost/ladybug/api/report/warningsAndErrors/errorGeneratingStorage
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    52    0    52    0     0   5777      0 --:--:-- --:--:-- --:--:--  6500HTTP/1.1 200
Date: Fri, 03 May 2024 08:58:54 GMT
Content-Type: text/plain
Transfer-Encoding: chunked

A simulated error, should show up in the Ladybug GUI

This test will be automated in the Cypress tests of ladybug-frontend. This can be done if the error is properly shown in the GUI, as is the final intention of this PR.

@mhdirkse mhdirkse requested a review from jacodg May 3, 2024 09:08
@jacodg jacodg merged commit be0bf9c into master May 3, 2024
1 check passed
@jacodg jacodg deleted the errorsAndWarningsOnApi branch May 3, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants