refactor: add name to view for the get views endpoint #256
Conversation
philipsens
changed the title
| public String toString() { | ||
| return getName(); | ||
| } | ||
| protected String name; |
There was a problem hiding this comment.
Can you keep whitespaces on tabs?
There was a problem hiding this comment.
This is the default java formatting in IntelliJ
There was a problem hiding this comment.
Please keep the formatting as is (like all other files in the project) to keep the project consistent and make reviewing easier
There was a problem hiding this comment.
I would like to, however there's no way to enforce this or tell my IDE to use a specific format, as there is none defined.
The only way to do this that I see is to ask ChatGPT to fix my indentation by supplying the new file and the old file with the indentation. I don't think that's supposed to be the way as it makes contributing to this project very cumbersome. Can you tell me how I can do this more efficiently?
There was a problem hiding this comment.
I tried to ask ChatGPT and it couldn't even do it.
There was a problem hiding this comment.
I fixed it as much as possible
| } | ||
|
|
||
| public Map<String, Object> toHashMap(boolean isDefaultView) { | ||
| Map<String, String> metadataTypes = new HashMap<>(); |
There was a problem hiding this comment.
Why call it toHashMap instead of toMap?
There was a problem hiding this comment.
Because Map is the interface type and HashMap the implemented returned type, I think it makes sense to return the actual type instead of its supertype.
There was a problem hiding this comment.
I would say use interface types for your "API" / what you expose to the outside world and use a specific type internally which you can change when needed without breaking the contract of your method (as far as I know this is common practice)
| return Response.status(Response.Status.BAD_REQUEST).entity("No settings have been provided - detailed error message - The settings that have been provided are " + map).build(); | ||
| } | ||
| private @Setter | ||
| @Inject |
There was a problem hiding this comment.
What happened on this line (newlines added)?
There was a problem hiding this comment.
It's the default java formatting again
In order to make sure that the view models have all the data needed in the frontend, I've added their name to the map that is returned in the endpoint, so the name is not just the key in the map.