Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zaak betalingsindicatie is not being translated #268

Closed
4 tasks
MLenterman opened this issue Feb 2, 2024 · 1 comment · Fixed by #273
Closed
4 tasks

Zaak betalingsindicatie is not being translated #268

MLenterman opened this issue Feb 2, 2024 · 1 comment · Fixed by #273
Assignees
Labels
bug Something isn't working released

Comments

@MLenterman
Copy link
Collaborator

Currently we dont see any errors, because an empty string betalingsindicatie is valid in ZGW. We need to add translations for betalingsindicatie from ZDS -> ZGW and back from ZGW -> ZDS in all relevant zaak translations.

  • Create translation betalingsindicatie ZDS -> ZGW
  • Create translation betalingsindicatie ZGW -> ZDS
  • Create tests for betalingsindicatie. Needs to cover creeerZaak, updateZaak without betalingsindicatie changing, updateZaak with betalingsindicatie changing and geefZaakDetails.
  • Add translations to all relevant zaak transformations

ZDS enum:

<simpleType name="BetalingsIndicatie">
	<restriction base="string">
		<enumeration value="N.v.t."/>
		<enumeration value="(Nog) niet"/>
		<enumeration value="Gedeeltelijk"/>
		<enumeration value="Geheel"/>
	</restriction>
</simpleType>

ZGW enum:

BetalingsindicatieEnum:
      enum:
        - nvt
        - nog_niet
        - gedeeltelijk
        - geheel
      type: string
    BlankEnum:
      enum:
        - ''
@MLenterman MLenterman added the bug Something isn't working label Feb 2, 2024
@DelanoWAF DelanoWAF self-assigned this Feb 2, 2024
@DelanoWAF DelanoWAF linked a pull request Feb 12, 2024 that will close this issue
@MLenterman
Copy link
Collaborator Author

🎉 This issue has been resolved in version 1.15.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants