fix: error handling Pipe ResultWithErrorMessage fails on TypeRolOmschrijving #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage-fails-on-typerolomschrijving
MLenterman
requested changes
Jan 8, 2024
| @@ -71,7 +76,7 @@ | |||
| <Param name="code" value="TechnicalError" /> <!-- codes: TechnicalError, TranslationError, ConfigurationError--> | |||
| <Param name="reason" | |||
| pattern="No roltype with matching omschrijving is found" /> | |||
| <Param name="details" pattern="omschrijving:{TypeRolOmschrijving} cannot be found in the list of roltypes"/> | |||
| <Param name="details" pattern="omschrijving: {TypeRolOmschrijving} cannot be found in the list of roltypes"/> | |||
There was a problem hiding this comment.
It is much easier to simply define TypeRolOmschrijving in the XsltPipe that is building the error itself as a param. A pattern tries to resolve the variable from a sessionKey or a param. The only thing to keep in mind with resolving from a param, is that it needs to be defined above the param with the pattern.
Also with ZaakBrug, always add ignoreUnresolvablePatternElements="true" when using patterns.
Example:
MLenterman
changed the title
MLenterman
approved these changes
Jan 11, 2024
MLenterman
deleted the
232-error-handling-pipe-resultwitherrormessage-fails-on-typerolomschrijving
branch
MLenterman
pushed a commit
that referenced
this pull request
Jan 11, 2024
## [1.14.3](v1.14.2...v1.14.3) (2024-01-11) ### 🐛 Bug Fixes * error handling Pipe ResultWithErrorMessage fails on TypeRolOmschrijving ([#255](#255)) ([6d9db22](6d9db22))
|
🎉 This PR is included in version 1.14.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.