fix: eindstatus duplicate check used less precise zaak einddatum instead of eindstatus datumstatusgezet resulting in duplicate check false positives #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLenterman
requested changes
Jan 31, 2024
src/main/configurations/Translate/Zgw/Zaken/Model/ZgwStatus.xslt
Outdated
Show resolved
Hide resolved
src/main/configurations/Translate/Zgw/Zaken/Model/ZgwStatus.xslt
Outdated
Show resolved
Hide resolved
|
Performing additional investigation into the safeguard that prevents duplicate results. It appears to be incorrect still and requires adjustment. |
|
Delays in test cases are necessary. The code still checks the datetime of statusDatumGezet to ensure that no two statuses were set at the exact same time. However, the safeguard for status type has been added to prevent a status from being added to a case more than once. Original code did include a minor version of the safeguard but this appeared to not enough, as well as not functioning correctly. |
MLenterman
approved these changes
Feb 12, 2024
…atuurlijk-peroon-updatezaak-sometimes-fails
MLenterman
approved these changes
Feb 12, 2024
MLenterman
changed the title
MLenterman
deleted the
262-soapui-testcase-suites4sociaaldomein-natuurlijk-peroon-updatezaak-sometimes-fails
branch
MLenterman
pushed a commit
that referenced
this pull request
Feb 12, 2024
## [1.15.9](v1.15.8...v1.15.9) (2024-02-12) ### 🐛 Bug Fixes * eindstatus duplicate check used less precise zaak einddatum instead of eindstatus datumstatusgezet resulting in duplicate check false positives ([#267](#267)) ([ce9d754](ce9d754))
|
🎉 This PR is included in version 1.15.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect XSLT condition caused loss of datetime information. Resolved now by replacing the condition in question.
Resolves #262