feat: provide translation profile defaults for configuring common settings appliyng to all zaaktype related custom translation profiles #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full baseProfile system is now useable. Sending any message of any type to the new configuration will return a version of Profile.json, as an XML, which has the baseProfile values added to every profile. It does not overwrite existing values or break the structure.
Adds baseProfile with some example elements. Can be changed where necessary.
4 tasks
MLenterman
requested changes
Mar 29, 2024
There was a problem hiding this comment.
-
It is not implemented anywhere yet. It should be implemented in
ImportValueOverridesFromTranslationProfileconfiguration instead of reading the profiles.json itself. Also every place in ZaakBrug that using values from the profile, should be changed to make use of the resolved profiles. -
Can you align the formatting with other adapters. You can use
ImportValueOverridesFromTranslationProfileas example. -
It is not merging array's like valueOverrides.
src/main/configurations/Translate/Configuration_ResolveProfileValues.xml
Outdated
Show resolved
Hide resolved
src/main/configurations/Translate/Configuration_ResolveProfileValues.xml
Outdated
Show resolved
Hide resolved
MLenterman
changed the title
checkiecheck
changed the title
checkiecheck
changed the title
checkiecheck
approved these changes
Apr 17, 2024
MLenterman
approved these changes
Apr 18, 2024
MLenterman
pushed a commit
that referenced
this pull request
Apr 18, 2024
## [1.18.0](v1.17.1...v1.18.0) (2024-04-18) ### 🍕 Features * provide translation profile defaults for configuring common settings applying to all zaaktype related custom translation profiles ([#296](#296)) ([81e9114](81e9114))
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to define a baseProfile, as well as giving the option to call the new ResolveProfileValues adapter. Upon being called it will then merge the baseProfile's values into every other profile while avoiding overwriting existing values and retaining the structure of the elements.
Note: A cache is active on this adapter. Processing is only done once.