fix: geefLijstZaakdocumenten should not return an error response when the zaak can't be found #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 18, 2024 23:21
…turns StUF:noValue="waardeOnbekend" in case no zaak is found
…ty in case no zaak found for GeefZaakDetails and GeefLijstZaakDocumenten requests
…entenAndGeefZaakDetails
…entenAndGeefZaakDetails
…entenAndGeefZaakDetails
MLenterman
approved these changes
Jun 25, 2024
MLenterman
changed the title
MLenterman
deleted the
GT-1189-ReturnNoErrorForGeefLijstZaakdocumentenAndGeefZaakDetails
branch
WeAreFrank-BOT
pushed a commit
that referenced
this pull request
Jun 25, 2024
## [1.19.9](v1.19.8...v1.19.9) (2024-06-25) ### 🐛 Bug Fixes * geefLijstZaakdocumenten should not return an error response when the zaak can't be found ([#395](#395)) ([d4ce003](d4ce003))
|
🎉 This PR is included in version 1.19.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adapters geefLijstZaakdocumenten and geefZaakDetails have this pipe which is retrieving the zaak that is requested.
If the zaak is not found then we were returning an error message mentioning 'no zaak is found with this {identificatie}'.
Now, instead of returning error we return empty object element with attributes StUF:entiteittype="ZAK" StUF:noValue="waardeOnbekend" inside antwoord element.