Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gt 1029 implement expand for openzaak api's when 1.11 openzaak is available #397

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

DelanoWAF
Copy link
Contributor

Adds an alternative to GeefLijstZaakdocumenten. GeefLijstZaakdocumentenExpand will be used only when GeefLijstZaakdocumentenExpand_Lv01.Active == true.

Expand functionality can be used in more places if deemed necessary or advantageous.

@DelanoWAF DelanoWAF added the feature New feature or request label Jun 24, 2024
@DelanoWAF DelanoWAF self-assigned this Jun 24, 2024
Copy link
Collaborator

@MLenterman MLenterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the experimental api call that was intended (open-zaak/open-zaak#1664), but nonetheless useful! Having a seperate experimental adapter is not needed for this though.

Could you merge this with the normal version of geefLijstZaakdocumenten? Then add a DeploymentSpecifics property zaakbrug.zgw.zaken-api.version=1.2. < 1.5 it should do the seperate getZaak call and getZaakInformatieObjecten. >= 1.5 it should do the getZaak with expand call.

For the experimental open-zaak/open-zaak#1664 ill make a seperate issue. It requires our development docker-compose openzaak version to be updated to 1.13 first though, but that seems to be more than a quick change.

@DelanoWAF
Copy link
Contributor Author

This is not the experimental api call that was intended (open-zaak#1664), but nonetheless useful! Having a seperate experimental adapter is not needed for this though.

This issue is new to me - Some miscommunication must have taken place at some point. Apologies for the confusion.

Could you merge this with the normal version of geefLijstZaakdocumenten? Then add a DeploymentSpecifics property zaakbrug.zgw.zaken-api.version=1.2. < 1.5 it should do the seperate getZaak call and getZaakInformatieObjecten. >= 1.5 it should do the getZaak with expand call.

Will do the merge ASAP.

@@ -13,6 +13,12 @@
<Exit name="EXCEPTION" state="ERROR"/>
</Exits>

<XmlIfPipe name="CheckApiVersion" xpathExpression="${zaakbrug.zgw.zaken-api.version} &lt; 1.5">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you can reference a property like in the xpathExpression like this. Usually it is needed to reference the property in a param and then reference the param in the xpathExpression. Can you check if setting zaakbrug.zgw.zaken-api.version >= 1.5 takes the correct forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants