Skip to content

Commit

Permalink
Merge pull request #1679 from weather-gov/jt/add-security-checks-to-r…
Browse files Browse the repository at this point in the history
…eview-template

add security considerations to review template
  • Loading branch information
jamestranovich-noaa committed Sep 3, 2024
2 parents a1c2af9 + 05587b5 commit 3366b9c
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions docs/code-review-templates/code-review-web.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,25 @@ This is an automated comment on every pull request requiring a review. A checked
## Documentation
- [ ] changes to “how we do things” are documented in READMEs
- [ ] all new functions and methods are commented using plain language
- [ ] any new modules added documented in contributed-modules.md
- [ ] any new Drupal modules are documented in `contributed-modules.md`

## Security
- [ ] security false positives are documented
- [ ] data from external sources is cleaned and clearly marked
- [ ] a change in permissions or workflow is audited
- [ ] a change in a library or Drupal module is vetted
- [ ] security false positives, if any, are documented

## Reliability
- [ ] error handling exists for unusual or missing values
- [ ] interactions with external systems are wrapped in try/except
- [ ] functionality is tested with unit or integration tests
- [ ] dependency updates in composer.json also got changed in composer-lock.json
- [ ] dependency updates in composer.json also got changed in `composer-lock.json`

## Infrastructure
- [ ] all changes are auditable and documented via a script
- [ ] it is clear who can and should run the script
- [ ] (if applicable) diagrams have been updated or added in PlantUML
- [ ] (if applicable) relevant SSPP controls are updated or have tickets to be updated

## Accessibility
- [ ] New pages have been added to cypress-axe file so that they will be tested with our automated accessibility testing
Expand Down

0 comments on commit 3366b9c

Please sign in to comment.