Skip to content

Commit

Permalink
Merge pull request #1496 from weather-gov/mgwalker/edge
Browse files Browse the repository at this point in the history
Rely on Playwright's built-in tools for downloading browsers
  • Loading branch information
greg-does-weather committed Jul 31, 2024
2 parents 7600348 + fd8d053 commit 9e14e0f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
2 changes: 0 additions & 2 deletions .github/actions/setup-playwright/action.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
runs:
using: composite
steps:
- uses: browser-actions/setup-chrome@v1
# - uses: browser-actions/setup-edge@v1
- uses: actions/setup-node@v4
with:
node-version: 18
Expand Down
11 changes: 6 additions & 5 deletions playwright.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const config = {
/* Retry on CI only */
retries: process.env.CI ? 2 : 0,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: process.env.CI ? 'blob' : 'html',
reporter: process.env.CI ? "blob" : "html",
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
use: {
/* Base URL to use in actions like `await page.goto('/')`. */
Expand Down Expand Up @@ -55,10 +55,11 @@ const config = {
// containerized.

/* Test against branded browsers. */
// {
// name: "Microsoft Edge",
// use: { ...devices["Desktop Edge"], channel: "msedge" },
// },
{
name: "Microsoft Edge",
use: { ...devices["Desktop Edge"], channel: "msedge" },
},

{
name: "Google Chrome",
use: { ...devices["Desktop Chrome"], channel: "chrome" },
Expand Down

0 comments on commit 9e14e0f

Please sign in to comment.