Merge pull request #1184 from weather-gov/ik/hourly-details-tweaks-5/24

Style adjustment to hourly details
weather-gov · May 9, 2024 · e33eff0 · e33eff0
2 parents e13315c + 516a5f5
commit e33eff0
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 20 deletions.
diff --git a/...ules/weather_blocks/src/Plugin/Block/Test/EndToEnd/HourlyForecast/HourlyForecast.php.test b/...ules/weather_blocks/src/Plugin/Block/Test/EndToEnd/HourlyForecast/HourlyForecast.php.test
@@ -62,21 +62,6 @@ final class HourlyForecastStructureTest extends EndToEndBase
         }
     }
 
-    /**
-     * @group e2e
-     */
-    public function testHourlyApparentTemperatureNullIfCloseToActual(): void
-    {
-        $this->onLocationRoute(33.521, -86.812);
-        $expected = null;
-
-        $data = $this->block->build();
-
-        $actual = $data["hours"][0]["apparentTemperature"];
-
-        $this->assertEquals($expected, $actual);
-    }
-
     /**
      * @group e2e
      */

diff --git a/web/modules/weather_data/src/Service/HourlyForecastTrait.php b/web/modules/weather_data/src/Service/HourlyForecastTrait.php
@@ -254,7 +254,7 @@ public function getHourlyForecastFromGrid(
 
             return [
                 "apparentTemperature" =>
-                    abs($apparentTemperature - $temperature) >= 5
+                    abs($apparentTemperature - $temperature) >= 0
                         ? $apparentTemperature
                         : null,
                 "conditions" => $this->t->translate(

diff --git a/web/themes/new_weather_theme/templates/partials/hourly-table.html.twig b/web/themes/new_weather_theme/templates/partials/hourly-table.html.twig
@@ -1,6 +1,6 @@
 {{ attach_library('new_weather_theme/hourly-table') }}
-<wx-hourly-table class="display-block position-relative margin-top-2 padding-top-1 bg-white">
-  <h5 class="visual-h4 margin-top-0">Hourly forecast</h5>
+<wx-hourly-table class="display-block position-relative margin-top-2 bg-white">
+  <h5 class="visual-h3 font-heading-md text-normal text-primary-darker margin-top-0 margin-bottom-205">Hourly forecast</h5>
 
   <div class="display-flex flex-justify">
     <div>

diff --git a/web/themes/new_weather_theme/templates/partials/precip-table.html.twig b/web/themes/new_weather_theme/templates/partials/precip-table.html.twig
@@ -1,10 +1,10 @@
 {% if precipHours %}
   <div class="grid-row"> 
     <div class="grid-col-12"> 
-      <h5 class="visual-h4 text-normal text-primary-darkest margin-top-1">{{ "Precipitation amounts" |t }}</h5>
+      <h5 class="visual-h3 font-heading-md text-normal text-primary-darker margin-top-1 margin-bottom-105">{{ "Precipitation amounts" |t }}</h5>
     </div>
   </div>
-  <div class="grid-row margin-x-neg-2 tablet:margin-x-0">
+  <div class="grid-row tablet:margin-x-0 tablet:grid-col-6">
     <table class="usa-table usa-table--borderless precip-table margin-y-0 width-full">
       <caption class="usa-sr-only">{{ "precipitation amounts for the coming hours" | t }}
         <thead class="usa-sr-only">