Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Interop layer] Parse links in alert descriptions #1594

Closed
7 tasks
Tracked by #1591
greg-does-weather opened this issue Aug 22, 2024 · 0 comments
Closed
7 tasks
Tracked by #1591

[Interop layer] Parse links in alert descriptions #1594

greg-does-weather opened this issue Aug 22, 2024 · 0 comments
Assignees
@eric-gade
Labels
DX Developer Experience Eng

Comments

@greg-does-weather
Copy link
Collaborator

Description

This logic already exists in PHP and needs to be translated over to the interop layer.

Acceptance criteria

  • Tests have been implemented or modified to capture the bug
    • turns valid .gov URLs into links
    • ignores non-.gov URLs
    • ignores URLs with embedded username/password
    • ignores non-HTTPs URLs
    • marks weather.gov URLs as internal/not external
    • marks non-weather.gov URLs as external
    • properly parses multiple links in the same description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eric-gade eric-gade

Labels
DX Developer Experience Eng
Projects
Roadmap & Sprint Board - Weather.gov 2.0
Status: 🎉 Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@colinmurphy01 @eric-gade @greg-does-weather @jamestranovich-noaa