Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather login customizations module for limiting access to basic auth features #1167

Merged
merged 8 commits into from
May 7, 2024

Conversation

loganmcdonald-noaa
Copy link
Member

@loganmcdonald-noaa loganmcdonald-noaa commented May 6, 2024

What does this PR do? 🛠️

Fixes #1006. We are adding a small module for the login experience that allows us to reroute a couple things and constrain login to SSO. In local dev and design test environments, we will still use username/password but in all other environments, SSO only. This also removes the /user/password and /user/register endpoints from public consumption.

Major shoutout to USA.gov for their open source work that helped me figure out this module!

For reviewers

ATTENTION! @eric-gade @greg-does-weather @igorkorenfeld this requires a change to local settings! Make sure to add the changed line or recopy settings.dev.yml!

Screenshots (if appropriate): 📸

Environments with basic auth see:
Screenshot 2024-05-06 at 4 08 32 PM

Environments with SAML enabled see:
Screenshot 2024-05-06 at 4 08 24 PM

Copy link
Contributor

github-actions bot commented May 6, 2024

It looks like our enabled modules has changed in this PR. Please ensure any documentation in https://github.com/weather-gov/weather.gov/tree/main/docs/contributed-modules.md has been updated!

@@ -845,3 +845,5 @@
];
$settings["config_sync_directory"] = "/opt/drupal/web/config/sync/";
$config["config_split.config_split.local"]["status"] = true;
$settings["weather_login_local_form"] = true;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the setting you have to update!!!

@loganmcdonald-noaa loganmcdonald-noaa force-pushed the lmm/1006-remove-register-pass-pages branch from b58642a to 4863e53 Compare May 6, 2024 23:46
@loganmcdonald-noaa loganmcdonald-noaa marked this pull request as ready for review May 6, 2024 23:59
Copy link
Collaborator

@greg-does-weather greg-does-weather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. This is cool! There's a lot of stuff going on in here. Nicely done!

Makefile Show resolved Hide resolved
Comment on lines 24 to 26
if ($settings_state || $state) {
$state = 1;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$state isn't defined prior, so I'm curious if the or is necessary.

@weather-gov weather-gov deleted a comment from github-actions bot May 7, 2024
@weather-gov weather-gov deleted a comment from github-actions bot May 7, 2024
@weather-gov weather-gov deleted a comment from github-actions bot May 7, 2024
@weather-gov weather-gov deleted a comment from github-actions bot May 7, 2024
@weather-gov weather-gov deleted a comment from github-actions bot May 7, 2024
@loganmcdonald-noaa loganmcdonald-noaa force-pushed the lmm/1006-remove-register-pass-pages branch from 41db5d1 to 1fea0b7 Compare May 7, 2024 16:15
Copy link
Contributor

github-actions bot commented May 7, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

@loganmcdonald-noaa loganmcdonald-noaa force-pushed the lmm/1006-remove-register-pass-pages branch from 1fea0b7 to 736fe81 Compare May 7, 2024 16:16
Copy link
Contributor

github-actions bot commented May 7, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

Copy link
Contributor

github-actions bot commented May 7, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

@loganmcdonald-noaa loganmcdonald-noaa merged commit e51617f into main May 7, 2024
19 checks passed
@loganmcdonald-noaa loganmcdonald-noaa deleted the lmm/1006-remove-register-pass-pages branch May 7, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove basic auth from the site and decide what we want out of a Drupal user/login page
2 participants