-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather login customizations module for limiting access to basic auth features #1167
Conversation
It looks like our enabled modules has changed in this PR. Please ensure any documentation in https://github.com/weather-gov/weather.gov/tree/main/docs/contributed-modules.md has been updated! |
@@ -845,3 +845,5 @@ | |||
]; | |||
$settings["config_sync_directory"] = "/opt/drupal/web/config/sync/"; | |||
$config["config_split.config_split.local"]["status"] = true; | |||
$settings["weather_login_local_form"] = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the setting you have to update!!!
b58642a
to
4863e53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. This is cool! There's a lot of stuff going on in here. Nicely done!
if ($settings_state || $state) { | ||
$state = 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$state
isn't defined prior, so I'm curious if the or
is necessary.
41db5d1
to
1fea0b7
Compare
This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file? |
1fea0b7
to
736fe81
Compare
This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file? |
This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file? |
What does this PR do? 🛠️
Fixes #1006. We are adding a small module for the login experience that allows us to reroute a couple things and constrain login to SSO. In local dev and design test environments, we will still use username/password but in all other environments, SSO only. This also removes the /user/password and /user/register endpoints from public consumption.
Major shoutout to USA.gov for their open source work that helped me figure out this module!
For reviewers
ATTENTION! @eric-gade @greg-does-weather @igorkorenfeld this requires a change to local settings! Make sure to add the changed line or recopy settings.dev.yml!
Screenshots (if appropriate): 📸
Environments with basic auth see:
Environments with SAML enabled see: