New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to API interop layer #1590

Merged

greg-does-weather merged 9 commits into main from api-interop-layer

Oct 25, 2024

Collaborator

greg-does-weather commented Aug 22, 2024 •

edited

Loading

What does this PR do? 🛠️

closes Switch to API interoperability layer #1591

What does the reviewer need to know? 🤔

Screenshots (if appropriate): 📸

greg-does-weather mentioned this pull request

Closed

jamestranovich-noaa reviewed

View reviewed changes

Collaborator

jamestranovich-noaa left a comment

Looks good! I had some general questions. I think we need app level monitoring sooner rather than later, it would be super nice to have it here so we would know exactly when it fails and why. Oh well.

.github/workflows/code-standards.yaml Outdated Show resolved Hide resolved

api-interop-layer/data/alerts/index.js Outdated Show resolved Hide resolved

api-interop-layer/data/alerts/index.js Outdated Show resolved Hide resolved

api-interop-layer/data/index.js Outdated Show resolved Hide resolved

greg-does-weather marked this pull request as ready for review

September 11, 2024 19:38

greg-does-weather marked this pull request as draft

September 11, 2024 19:39

greg-does-weather force-pushed the api-interop-layer branch 2 times, most recently from e7abf7e to d1d0384 Compare

September 12, 2024 21:46

Contributor

github-actions bot commented Sep 12, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

1 similar comment

Contributor

github-actions bot commented Sep 13, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

eric-gade force-pushed the api-interop-layer branch 2 times, most recently from 61bdf9e to 9a65274 Compare

September 26, 2024 16:24

Contributor

github-actions bot commented Sep 26, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

2 similar comments

Contributor

github-actions bot commented Sep 26, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

Contributor

github-actions bot commented Sep 26, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

jamestranovich-noaa force-pushed the api-interop-layer branch from b686bc3 to 4c0a9bf Compare

September 26, 2024 20:31

Contributor

github-actions bot commented Sep 26, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

greg-does-weather force-pushed the api-interop-layer branch from 0e80435 to e89e069 Compare

October 3, 2024 18:16

Contributor

github-actions bot commented Oct 3, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

1 similar comment

Contributor

github-actions bot commented Oct 3, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

greg-does-weather force-pushed the api-interop-layer branch from e2ba956 to cbfb777 Compare

October 9, 2024 22:19

Contributor

github-actions bot commented Oct 9, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

2 similar comments

Contributor

github-actions bot commented Oct 10, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

Contributor

github-actions bot commented Oct 10, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

jamestranovich-noaa force-pushed the api-interop-layer branch from ef56d80 to ea9767e Compare

October 10, 2024 20:49

github-advanced-security bot found potential problems

View reviewed changes

api-interop-layer/util/fetch.js Dismissed Show dismissed Hide dismissed

scripts/compile-svg-sprite.js Dismissed Show dismissed Hide dismissed

greg-does-weather force-pushed the api-interop-layer branch 2 times, most recently from 89e72a4 to e56816f Compare

October 23, 2024 17:02

greg-does-weather marked this pull request as ready for review

October 23, 2024 17:03

jamestranovich-noaa approved these changes

View reviewed changes

greg-does-weather and others added 2 commits

October 24, 2024 16:12


          api interop layer

7d9b468

Co-authored-by: Eric Gade <eric.gade@noaa.com>
Co-authored-by: James Tranovich <james.tranovich@noaa.gov>
Co-authored-by: Greg Walker <michael.walker@noaa.gov>


          [Interop layer] Update QPF table and chart so they are always shown (#…

112a01c

…1965)

* always show qpf table and chart

* fix up lint rules

* dep bump

greg-does-weather and others added 5 commits

October 24, 2024 16:12


          [Interop layer] Use a database connection pool (#1964)

ab0333d

* use a connection pool

* fix up database pool mocking

* undefined rather than false

* fix bug with alert in today summary forecast


          Interop fixups (#1973)

b631123

* fixups

* fix condition description


          weather story upload integration (#1946)

994d226

* weather story: stub out block

* weather story: styling tweaks

* weather story: add wfo name

* weather story: add svg icons

* weather story: clean up code

* weather story: hide county overview

* weather story: update layout


          config split: enable s3fs for uploads on cloud.gov (#1971)

5b5bc33


          Update app name

8b5b6a8

greg-does-weather force-pushed the api-interop-layer branch from db27378 to 8b5b6a8 Compare

October 24, 2024 21:14

greg-does-weather added 2 commits

October 24, 2024 16:16


          Merge branch 'main' into api-interop-layer

e9f83b3


          fix reference to story image

ae97c6e

greg-does-weather merged commit f711b4c into main

20 of 21 checks passed

greg-does-weather deleted the api-interop-layer branch

November 7, 2024 16:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet