interop test for daily forecast #1823
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-gade
force-pushed
the
api-interop-layer
branch
from
61bdf9e
to
9a65274
Compare
…eometries API interop tests: alert geometries
jamestranovich-noaa
force-pushed
the
jt/api-interop-test-daily-forecast-days
branch
from
e82f90c
to
05e6963
Compare
jamestranovich-noaa
force-pushed
the
api-interop-layer
branch
from
b686bc3
to
4c0a9bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
Addresses #1603
What does the reviewer need to know? 🤔
This is not a 1:1 PHP to JS test. Rather, we are testing the daily function in isolation, which I think makes more sense. Still a bit TBD on how exactly to test this, as we aren't passing the current time to evaluate daily forecast (at least for this function).