Alert description / url parsing tests #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestranovich-noaa
approved these changes
Sep 26, 2024
Oops! Yes, good catch |
eric-gade
force-pushed
the
api-interop-layer
branch
from
61bdf9e
to
9a65274
Compare
eric-gade
force-pushed
the
eg-1600-alert-description-parse-tests
branch
from
9a2f147
to
e8ffa3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
Implements tests outlined in #1600.
Note also that it appears the work from #1594 was already done. This PR implements the corresponding tests for those as well, finishing the port of tests from
WeatherAlertParser.php.testWhat does the reviewer need to know? 🤔
It's a straight translation.