PoP Refactoring #2050
Merged
PoP Refactoring #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- What In our test data, there are gaps in the gridpoint PoP hourly information. These might not exist in real life, but we should check for them when trying to compute a max PoP for a given period/day. If there is no `probabilityOfPrecipitation` for a given hour, we return 0 as the probability when trying to compute the max for the period.
jamestranovich-noaa
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
Implements the proposed Probability of Precipitation (PoP) data issues outlined in #1982
What does the reviewer need to know? 🤔
Though it's a bunch of complicated munging, there's not much to know. One exception: we currently round to the nearest 5 place using normal
Mathrounding rules, meaning that things like 9 will round up to 10. If this is not ok @shadkeene we can fix to round down.Screenshots (if appropriate): 📸
Mobile
Desktop