Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoP Refactoring #2050

Merged
merged 11 commits into from
Nov 14, 2024
Merged

PoP Refactoring #2050

merged 11 commits into from
Nov 14, 2024

Commits on Nov 5, 2024

  1. Initial version of hourly pop max munging

    @eric-gade
    eric-gade committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    060e227 View commit details
    Browse the repository at this point in the history

  2. Adding tests and fixing logic

    @eric-gade
    eric-gade committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    6332757 View commit details
    Browse the repository at this point in the history

  3. Adjusting templates to comply with new structure

    @eric-gade
    eric-gade committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8a961ed View commit details
    Browse the repository at this point in the history

  4. lints

    @eric-gade
    eric-gade committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f81704e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into eg-1982-fix-daily-high-low-calc

    @eric-gade
    eric-gade authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3766253 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Fixing test assumption

    @eric-gade
    eric-gade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a3e8809 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into eg-1982-fix-daily-high-low-calc

    @eric-gade
    eric-gade authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e5644ee View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Fixing for PoP edge case in gridpoints endpoint 

    -- What
In our test data, there are gaps in the gridpoint PoP hourly
information. These might not exist in real life, but we should check
for them when trying to compute a max PoP for a given period/day.

If there is no `probabilityOfPrecipitation` for a given hour, we
return 0 as the probability when trying to compute the max for the period.
    @eric-gade
    eric-gade committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    85d2944 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into eg-1982-fix-daily-high-low-calc

    @eric-gade
    eric-gade authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    86c8763 View commit details
    Browse the repository at this point in the history

  3. Re-commit name change

    @eric-gade
    eric-gade committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f4a5f8f View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Merge branch 'main' into eg-1982-fix-daily-high-low-calc

    @eric-gade
    eric-gade authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    106a395 View commit details
    Browse the repository at this point in the history