api interop layer: setup private comms #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-does-weather
approved these changes
Nov 7, 2024
jamestranovich-noaa
force-pushed
the
jt/api-interop-layer-private-comms
branch
from
8e00b32
to
421f1e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
This is mainly for production and is intended to show how to set up secure container-to-container networking between the API interop layer and Drupal. Closes #1895
What does the reviewer need to know? 🤔
We'll need to do this on a case by case basis. The interop layer in the
jamesenv is protected and offered up as a (working) example. We'll do this withbetaonce we confirm all looks good. But generally environments may not wish to have their api interop layer protected.