Spatial data management tweaks action #2064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-does-weather
force-pushed
the
spatial-data-management-tweaks-action
branch
from
c93fe5c
to
ffc102b
Compare
|
The approaches from this PR won't work. I was trying to just reuse our existing script, but it depends on the Docker runner being the same machine that the cf SSH tunnel is listening on. That's fine in our local dev environments, but it breaks in GitHub where the Docker runner is a remote host. I think a workable solution would be to create another container that hosts the cf cli and that container would establish the SSH tunnel to cloud.gov. Running that container on the same virtual network as the spatial container should solve the problem of them being able to communicate. And I think this approach is more robust anyway, making fewer assumptions about the systems external to Docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
What does the reviewer need to know? 🤔
Screenshots (if appropriate): 📸