Add intermediate statuses to Explorer

[opudrovs]

Closes #3679

• Added intermediate Explorer object statuses (based on how intermediate object statuses are currently computed on the frontend ).

• Added SuspendableAdapter for computing the Suspended object status.

• Expanded status and message tests for Explorer objects.

• Added showing icons for intermediate Explorer object statuses in the Explorer UI (based on how icon type and color are currently computed on the frontend in the non-Explorer UI).

• Added unit and snapshot tests for rendering UI indicators of Explorer object statuses.

• Renamed AutomatedClusterDiscoveryAdaptor to AutomatedClusterDiscoveryAdapter for consistency with other adapters.

• Removed empty line(s) for consistency (this is optional, if there is a reason those lines were added, can put them back).

• Re-arranged some (one old and two new) object type switch cases alphabetically based on object Kind without package name, for readability. Can re-arrange them back if needed.

Screenshots of the new intermediate statuses in Explorer UI:

Testing:

• You can just check out the branch and test that you see the new intermediate object statuses (Reconciling and Suspended) in Explorer. The PendingAction status is possible for TF objects only (because it checks for the TerraformPlannedWithChanges condition reason), which are not supported by Explorer yet.

Notes:

• I had to use a fake Kustomization with a TF object condition in a unit test for the PendingAction object status because Explorer for now does not support TF objects and it's beyond the scope of the current issues to add them.

Added a to-do to replace this fake TF objects with a real TF object after support for TF objects is added to Explorer.

• It's the best I can do with adapters. 😅 If you knwo of a better way to add getting the value of Spec.Suspend from underlying Flux objects in Explorer's FluxObject, any suggestions are most welcome.

• In pkg/query/configuration/fluxobject_test.go, I had to change the type of test object from FluxObject to client.Object because with the new adapter added I was getting an error: [object kind] does not implement FluxObject (missing method GetSuspended.

Questions:

1. Should the object message is computed be reworked with taking some intermediate statuses into account? Or is using only message from object Condition with type Ready or Available, as now, still OK?

2. Based on the frontend logic (how the icon is picked for different statuses), the icon for the NoStatus status is RemoveCircleIcon instead of the same icon as the error icon, which before was used for both Failed and NoStatus status.

3. Should any of the custom status functions used by the following objects:

PolicyAgentAuditEventObjectKind

weave-gitops-enterprise/pkg/query/configuration/objectkind.go

Line 228 in 1172c1d

StatusFunc: func(obj client.Object) ObjectStatus {

GitopsTemplateObjectKind

weave-gitops-enterprise/pkg/query/configuration/objectkind.go

Line 268 in 1172c1d

StatusFunc: func(obj client.Object) ObjectStatus {

CapiTemplateObjectKind

weave-gitops-enterprise/pkg/query/configuration/objectkind.go

Line 293 in 1172c1d

StatusFunc: func(obj client.Object) ObjectStatus {

be reworked too to include intermediate statuses? Do intermediate statuses make sense for any of the objects which use custom status functions? I guess not (those objects cannot be suspended or reconciled, I mean similar to Applications and Sources, correct?) but wanted to check.

4. Should the Ready status for test Explorer objects data in the existing frontend tests (for example, here) be updated to Success, to match the way it is returned from the backend (currently in the main branch too, Success is returned)? In the new UI snapshot test, I used the Success status in test objects.

[opudrovs]

@enekofb @jpellizzari changes addressed, please re-review.

Main changes:

• Added @enekofb 's suggestions on passing anonymous functions for getting conditions and suspend with each object kind. Thanks, Eneko! ✨

• Removed adapters and toFluxObject converter, we don't need them or those long switch statements anymore. 😄

• Added returning errors from StatusFunc and MesageFunc based on @enekofb's TODO "need to return an error" comment Please check if it is the kind of error handling you had in mind.

• Added passing object kind with test objects in fluxobject_test.go because we now need access to the real ObjectKind's get conditions and suspended functions.

I will squash the commits after the PR is approved, keeping them for higher visibility of the latest changes.

Tested the branch locally, the intermediate statuses are visible in Explorer after the latest changes:

[enekofb]

added @weaveworks/pesto and @weaveworks/timber-wolf for visibility (not required approval) but to be aware of the PR for the changes around their affected resources

[enekofb]

Tested the functionality using suspended as example

approved with minor cleanup suggestions (no blockers)

Shalllow skimmed through FE changes, dont trust my review in that sense.

[opudrovs]

@enekofb re-tested it locally, working as expected. The latest comments addressed. If there are no more changes required, I am merging it.