Skip to content

Commit

Permalink
Fix hr related message appearing on ks (#4066)
Browse files Browse the repository at this point in the history
* Fix hr related message appearing on ks

* Fix hr related message appearing on ks - updated
  • Loading branch information
AlinaGoaga authored Oct 4, 2023
1 parent 2be4102 commit 006ed40
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions ui/components/AutomationDetail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import Timestamp from "./Timestamp";
import YamlView from "./YamlView";

const hrInfoMessage =
"spec.Kubeconfig is set on this HelmRelease. Details about reconciled objects are not available.";
"spec.kubeConfig is set on this HelmRelease. Details about reconciled objects are not available.";

type Props = {
automation: Automation;
Expand Down Expand Up @@ -83,6 +83,10 @@ function AutomationDetail({

const canaryStatus = createCanaryCondition(data?.objects);
const health = computeAggHealthCheck(data?.objects || []);
// We cannot show reconciled objects for remote HelmReleases
const skipReconciledObjectsTable =
automation.type === "HelmRelease" &&
(automation as HelmRelease).kubeConfig !== "";

const defaultTabs: Array<routeTab> = [
{
Expand All @@ -91,8 +95,7 @@ function AutomationDetail({
component: () => {
return (
<RequestStateHandler loading={isLoading} error={error}>
{automation.type === "HelmRelease" &&
(automation as HelmRelease).kubeConfig === "" ? (
{!skipReconciledObjectsTable ? (
<ReconciledObjectsTable
className={className}
objects={data?.objects}
Expand Down

0 comments on commit 006ed40

Please sign in to comment.