-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates user guide page names and links #3904
Conversation
bcca2bc
to
e041bd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the section within website/docs
as i assumed is the main part and the part on v0.28
are backporting or adjusting changes but not new content.
it looks generally good, added small comments to enhance it.
Also added a question about the cert-manager section within tls. it seems there is something missing in terms of scope or content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replied and expanded to the open items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking into consideration the comments.
The cert-manager section seems still having some changes in this PR. Not sure if that is expected. Asked in the thread,
Regarding aligning getting started
, there are some other docs that might require the same alignment. Suggested in this comment. For example this suggestion. There might be other ones. It could be good to review to ensure we have consistency.
Last comment, is given we are in v0.29 whether makes sense to just dont backport the changes of this PR to v0.28 or if there is anything in particular we are looking in that version.
257af65
to
599a8a0
Compare
9d7260d
to
76523ba
Compare
02cf43e
to
3179b5c
Compare
2fcc9af
to
714d860
Compare
Co-authored-by: Yiannis <8741709+yiannistri@users.noreply.github.com>
Moves cert-manager guide text to page
Fix bullet points
Co-authored-by: Eneko Fernández <12957664+enekofb@users.noreply.github.com>
Co-authored-by: Eneko Fernández <12957664+enekofb@users.noreply.github.com>
Co-authored-by: Eneko Fernández <12957664+enekofb@users.noreply.github.com>
714d860
to
6ca4147
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix doc ci job
Updated a number of page names that were vague in the context of other pages (GitOpsSets, Pipelines, GitOps Run sections), and fixed resulting broken links. Minor punctuation and other fixes scattered throughout. PR also updates the sidebars.js for main and last version (0.28.0) and the 0.28.0 docs.
The linter snagged on a reference in the "Install WGE" page to our Helm reference page, but I didn't edit that page. The link looks fine, so not sure what's going on.